5 jili casino login register philippines,PHMAYA com login Register.Recharge Every day and Get Bonus up-to 50%!

Resolved ellewilliams
(@ellewilliams)

7 years, 5 months ago

Hi,

Great plugin!

One issue I am currently facing is using scroll-lock. It works perfectly on the desktop site (sidebar at 50% screen width), but on mobile (Safari) at 100% screen width, when you get to the very bottom of the sidebar the page freezes and you cant scroll up or down. I don’t have this issue when I turn off scroll-lock.

Since I would like to use scroll-lock for desktop, is there a way of enabling/disabling it at certain screen sizes?

Cheers

Viewing 4 replies - 1 through 4 (of 4 total)

Plugin Author Jory Hogeveen
(@keraweb)

7 years, 5 months ago

Hi @ellewilliams,

Good find! I never actually tested 100% width of sidebars. I see it behaves differently when testing in Chrome dev move as well.

Currently scroll-lock is simply on or off. I do like the idea though!
You can code your own script for disabling scroll based on the screen width.
More info: https://github.com/JoryHogeveen/off-canvas-sidebars/wiki/JavaScript-API

I’ve added a GitHub issue for this request.
https://github.com/JoryHogeveen/off-canvas-sidebars/issues/39

Regards, Jory
Plugin Author Jory Hogeveen
(@keraweb)

7 years, 5 months ago
Hi @ellewilliams,

Please test these changes and let me know if it also works for you!
https://github.com/JoryHogeveen/off-canvas-sidebars/commit/eaece27171c042a4cd1e14555996c3bbd6d21404

With this fix you can simply overwrite this plugin’s CSS to enable/disable scroll lock based on the device width.

Regards, Jory
- This reply was modified 7 years, 5 months ago by Jory Hogeveen.
Thread Starter ellewilliams
(@ellewilliams)

7 years, 5 months ago

Hi Jory,

This works perfectly. Thank you so much!

I will be donating you a beer for this!

Thanks,
Elle

Plugin Author Jory Hogeveen
(@keraweb)

7 years, 5 months ago

Hi Elle,

Great to hear and thanks for the beer! ??
I will make an official 0.4.1 update a.s.a.p.

Thanks again and if you have the time, please leave review, it will help this plugin grow ??
https://www.ads-software.com/support/plugin/off-canvas-sidebars/reviews/

Cheers, Jory

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Compatibility of scroll-lock on mobile sites’ is closed to new replies.