Compatibility with Vantage

  • Resolved ro3ert

    (@ro3ert)


    8 years, 9 months ago

    Hi, as you wrote at plugins setup: “If this plugin is not working as it should then your theme might not be compatible with this plugin, please let me know!” I am here to let you know that plugin is not working the best with Vantage template
    https://www.ads-software.com/themes/vantage/.

    Standard procedure which you describe (<?php do_action(‘website_before’); ?> and <?php do_action(‘website_after’); ?>) is not enough.

    P.S. Great plugin. It is unique. Very clear and functional admin interface.

    If you can help me to integrate the code in child template let me know.

    Thank you.

    https://www.ads-software.com/plugins/off-canvas-sidebars/

Viewing 7 replies - 1 through 7 (of 7 total)

  • Alex S from SiteOrigin here.

    The Vantage theme includes two actions that are able to be used in a similar method to what is described in your installation document.

    vantage_before_page_wrapper
    vantage_after_page_wrapper

    Both hooks are in the correct places (after <body> and before </body>).

    It should be noted that the “pushes” style causes the sidebar to be moved.

    The overlay method works as intended.

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi Robert and Alex S,

    Tested the functionality here and this theme works fine.
    I will patch an update today so (if the theme supports this) the user can set their own action names for de before and after hooks.

    Robert, after the update, please let me know if it works for you!

    Thread Starter ro3ert

    (@ro3ert)

    Jory,

    thank you for you answer.

    I have found out that part which is called /* EXPERIMENTAL */ on the line 53 in off-canvas-sidebars-frontend.class.php if enabled somehow “fixes” some parts. However .css which is fundamental for plugin to work interfere with original template .css. For example Vantage from SiteOrign has “sticky menu” which works fine but after activating the plugin it does not stick anymore.

    I will try to find which part of code is stoping sticky menu and than let you know.

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi Robert,

    I’ve just made an update to 0.1.1. I’ve tested it here with Vantage aswell en it looks fine.

    Unfortunately, fixed elements won’t work with slidebars the usual way.

    See these articles for mor info:
    https://plugins.adchsm.me/slidebars/issues/fixed-position.php
    https://stackoverflow.com/questions/2637058/positions-fixed-doesnt-work-when-using-webkit-transform

    Plugin Author Jory Hogeveen

    (@keraweb)

    Update on the fixed elements:

    Since this is a issue that probably won’t be fixed I’ve tried to search for other sollutions.

    On of them is targeting all fixed elements in the DOM and adding the css “top” property with the scrollTop of the window.
    It’s not the most neat solution but it works..

    One problem. If the fixed element is allready getting the top property from an other script it is possible that this will be overwritten. Like with the Vantage theme the main menu is getting a “top: 0px” and this overwrites the top property I am adding with this plugin.

    To be continued, just wanted to give an update ??

    Thread Starter ro3ert

    (@ro3ert)

    Thank you. I will keep an eye on follow-up. ??

    Plugin Author Jory Hogeveen

    (@keraweb)

    Update on the fixed elements:

    0.1.2 is live and has a new feature to enable fixed elements within the site container.

    Instead of the top css property I use the -webkit-transform and the -moz-transform properties. I also use the current positioning of top and bottom properties in the calculations so the fixed elements within the site container will behave as default fixed elements.
    At this point it doesn’t have the best performance but it works…

    I am thinking about changing the Slidebars code to let this plugin decide what kind of animation is used. Currently (if the browser supports this) it defaults to use the tranform animations to enable hardware acceleration.

    I’ve marked this topic as fixed.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Compatibility with Vantage’ is closed to new replies.