• Resolved jugadelpi

    (@jugadelpi)


    Hello,

    Could you please add compatibility with the following premium theme:

    Venedor

    The menu buttom is not displaying pages when viewing the website in cellphone.

    The only workaround I have found is to disable js minification.

    Best regards,
    Gabriel

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Raul P.

    (@alignak)

    This is most probably the same thing as the other thread:
    https://www.ads-software.com/support/topic/compatibility-with-mb-ytplayer-background-video-plugin/

    Not all theme and plugin authors follow best practices, unfortunately.

    You can try to add the relevant js file to the ignore list. I usually start by adding them all and then removing one by one until I find which one causes trouble.

    Thread Starter jugadelpi

    (@jugadelpi)

    Hello,

    I don’t think this problem is still resolved as you marked it. However, I discovered the root of the problem.

    The problem is not actually js minification, it is actually the js merging feature.

    In the plugin description you specified that this plugin has the ability to turn off merging.
    However, there is no such option. I’m only able to turn off minification but I am not able to turn off merging without letting the minification feature enable.

    Could you please add the option to disable only merging but letting the minification feature work as it is described in the plugin’s description?

    Best regards,
    Gabriel

    Plugin Author Raul P.

    (@alignak)

    Hi,

    You can disable merging by disabling the js processing, however it disables minification also.

    This is because most of the time, incompatibility problems are more common with minification than simple merging. By the way, does it work when you disable minification only?

    There are a few cases where some plugin is poorly coded and it conflicts with other files when merged (minified or not), therefore the option to disable js processing exists.

    However, the true solution lies with the ignore list as I referred earlier, especially if you now know there’s a problem with merging the files.

    You can try to add the relevant js file to the ignore list. I usually start by adding them all and then removing one by one until I find which one causes trouble.

    If you do this, you can keep merging and minification working.

    If I add the minification only but no merging, there wouldn’t be any benefit in speed if your content is already gziped (few bytes worth).

    Even with http2, there’s much more benefit in reducing requests by merging than to minify.

    I also said there’s an option to disable merging but didn’t necessarily said that you could minify or do anything else if you disable merging. I understand some people might take it differently, but my intention with “disable merging” was to say, that you could disable the processing (merging + minification).

    I have that featured planed, since it seems to be a popular request but not right now.

    If you need me to help you check which file needs to be on the ignore list, let me know.
    A usual file is the select2 library… they have a utf-8 encoding error for years and don’t seem to want to fix it… this however, breaks merging.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Compatibility with Venedor Theme’ is closed to new replies.