Compatibility with WC FSE blocks

  • Resolved robvandenbogaert

    (@robvandenbogaert)


    1 year, 8 months ago

    Hey there!

    I was searching for a Wishlist plugin that is fully compatible with the new WooCommerce Full Site Editing blocks (not the classic template block, but the new split up block). I was not able to found one, but yours came close. I just had to make 1 change in the plugin code to make it work, I was hoping you could test this and implement in the next version, so I don’t have to worry about re-applying this fix after updates.

    Because for whatever reason the global variable $product is just the name of the product in my usecase, I needed to add the following to the Shortcode.php files on line 49:

    else if (get_post_type(get_the_ID()) === 'product') {
  $product_id = get_the_ID();
}

    Perhaps this fix needs more detail to it, I was not able to fully test it in all possible use cases, but I was hoping you can build a permanent fix in the next release. Usefull to know: Without the fix, the data-product_id in the add to wishlist button was empty.

    Kind regards,

    Rob van den Bogaert @ Maatwerk Online

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Contributor Tarek Aziz

    (@tarekht)

    Hi Rob van den Bogaert,

    Thank you very much for getting in touch with us ??

    It’s great to hear that you are using our plugin and I highly appreciate you sharing the fix you have used to make the plugin compatible for now.

    You are right that this fix won’t be enough for all use cases. Don’t worry; we’ll test the plugin for all possible use cases and do our best to add compatibility in a future update of our plugin.

    Best regards,
    Tarek Aziz

    Thread Starter robvandenbogaert

    (@robvandenbogaert)

    Hi Tarek,

    Thanks for your response. For now I have made that change without the plugin files we are using and changed the versionnumber to version 999.x.x. Could you let me know when you have applied a fix for this so I can start using your latest version again? Thank you!

    Kind regards,

    Rob

    Plugin Contributor Tarek Aziz

    (@tarekht)

    Hi Rob,

    Good morning from here ??

    Yes, of course. We’ll inform you immediately after we have released the update with a fix to the issue you encountered.

    Thank you very much!

    Plugin Contributor Tarek Aziz

    (@tarekht)

    Hi Rob,

    I hope you are having a great day!

    Just wanted to inform you that we have already added a fix to the plugin and released an update.

    Could you please try using the latest version? I would greatly appreciate it if you could inform me whether it was helpful or not.

    Thank you very much,
    Tarek

    Thread Starter robvandenbogaert

    (@robvandenbogaert)

    Hi Tarek,

    Thank you for your response and for adding this fix so quickly. I was on vacation, so did not get to testing the update yet. I will get to that this week and let you know if it still works as well.

    I did take a moment to check the source files of the new release and noticed that you have used my fix without changes, very happy to see that ??

    I’ll get back to you asap!

    Kind regards,

    Rob

    Plugin Contributor Tarek Aziz

    (@tarekht)

    Hi Rob,

    It was an absolute pleasure for me.

    Your request was literally at the top of our priority list. Thanks for going through the source files by the way.

    We do appreciate your assistance. Please test the updated version of the plugin when you find it convenient and share your precious feedback ??

    I will eagerly await your response.

    All the best,
    Tarek

    Thread Starter robvandenbogaert

    (@robvandenbogaert)

    Hey Tarek!

    Just tested it, works like a charm, thank you very much!

    I’m liking the plugin in general, I might consider adding a Dutch translation to it, if that is helpful at all. I’m trying to find some interesting plugins to contribute some of my free time to.

    Since wishsuite is now one of the only, if not the only free wishlist plugin that is compatible with full site editing blocks, this seems like a good place to start!

    Kind regards,

    Rob

    Plugin Contributor Tarek Aziz

    (@tarekht)

    Hey Rob,

    Thanks a lot for taking the time to share your valuable thoughts.

    Of course, it will be of great help ?? In fact, it would be awesome if you could contribute to the Dutch translation of the plugin ??

    It’s wonderful to see that you already have made contributions to the translation of the Advanced Custom Fields (ACF) plugin into Dutch ??

    Finally, I just want to say that it makes us happy that we were able to help. If there is anything else that we can assist you with, please let us know without any hesitation.

    Furthermore, we are always open to any kind of feedback. Hence, if you have any other feature requests or suggestions that would further improve the plugin, just give us a ping.

    Our support team is always here to assist you.

    Wishing you a fantastic day ahead! ??

    Sincerely,
    Tarek

    • This reply was modified 1 year, 8 months ago by Tarek Aziz.
    • This reply was modified 1 year, 8 months ago by Tarek Aziz.
Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Compatibility with WC FSE blocks’ is closed to new replies.