Compatible with PHP 8.0, 8.1?

2.2.2 is ancient, there are no more curly braces in more recent versions (see https://github.com/futtta/autoptimize/blob/beta/classes/autoptimizeStyles.php#L1142) and AO indeed does work fine under PHP8 ??

hope this helps,
frank

@optimizingmatters, thanks for the answer. I have updated the plugin.

Your plugin have small bugs in the old and new versions.

In this classes:

autoptimize/classes/autoptimizeScripts.php
autoptimize/classes/autoptimizeStyles.php

The code inspector shows “script” next to “/body”. Visually bad

In this code on autoptimizeScripts.php:

$bodyreplacementpayload = '<script ' . $type_js . $defer . 'src="' . $this->url . '"></script>';

I see in inspector:

...some code...
<script defer src="https://domain.ru/wp-content/cache/autoptimize/js/autoptimize_c8dd705d1d4aa47ee037557413d3b89b.js"></script></body>

I made the code like this (add PHP_EOL):

$bodyreplacementpayload = '<script ' . $type_js . $defer . 'src="' . $this->url . '"></script>' . PHP_EOL;

And i see:

...some code...
<script defer src="https://domain.ru/wp-content/cache/autoptimize/js/autoptimize_c8dd705d1d4aa47ee037557413d3b89b.js"></script>
</body>

This is also in autoptimizeStyles.php:

$this->inject_in_html( apply_filters( 'autoptimize_filter_css_bodyreplacementpayload', '<link ' . $type_css . 'media="' . $media . '" href="' . $url . '" rel="stylesheet">'), $replace_tag );

I made the code like this (add PHP_EOL):

$this->inject_in_html( apply_filters( 'autoptimize_filter_css_bodyreplacementpayload', '<link ' . $type_css . 'media="' . $media . '" href="' . $url . '" rel="stylesheet">' . PHP_EOL ), $replace_tag );

In the file autoptimizeStyles.php there are several lines at once where it would be useful to add PHP_EOL:

Line 1022
Line 1062
Line 1069
Line 1071

Sorry for my bad english ??

AO does not aim to deliver visually pleasing HTML I’m afraid kirpich1; when “optimize HTML” is on (which is almost always the case) all linebreaks are removed anyway ??

And also the W3C validator shows INFO message when i checking my site with HTML5.

Info messages are associated with the final slash in the link tags.

$this->inject_in_html( apply_filters( 'autoptimize_filter_css_bodyreplacementpayload', '<link ' . $type_css . 'media="' . $media . '" href="' . $url . '" rel="stylesheet" />' . PHP_EOL ), $replace_tag );

I mean this:

rel="stylesheet" />    <-- /

Some users do not enable HTML optimization. I don’t enable this function for some reasons ??

when “optimize HTML” is on (which is almost always the case) all linebreaks are removed anyway

• This reply was modified 2 years, 2 months ago by kirpich1.
• This reply was modified 2 years, 2 months ago by kirpich1.

Apologies for my poor English.

I tweaked the plugin code for myself.

Probably this will help you in development. The idea itself may be useful to you. And its implementation is very simple.

Thank you for the great plugin!

well, if you really want, you can use a filter like this one to remove the closing slash and add the EOL (and use autoptimize_filter_js_bodyreplacementpayload for JS);

add_filter( 'autoptimize_filter_css_bodyreplacementpayload', function( $html ){
    return str_replace( '/>', '>' . PHP_EOL , $html );
});

that’s better then tweaking the code (as your tweaks could be overwritten with the next update(s)? ??

I understand that. But I haven’t updated your plugin since version 2.2.2 ?? I want to switch to PHP 8.1. That’s why I’ve made an update now.

that’s better then tweaking the code (as your tweaks could be overwritten with the next update(s)?

How to add a filter to functions.php for all the strings I need? ??

if you add the above snippet + a similar snippet for JS (using that other filter mentioned) and add it using the code snippets plugin (as functions.php gets overwritten by theme updates), all strings you mentioned earlier will likely be the way you want them ??

@optimizingmatters, thank’s for answers! Good developer ??

Resolved

• This reply was modified 2 years, 2 months ago by kirpich1.

you’re welcome, feel free to leave a review of the plugin and support here! ??

@optimizingmatters, ok. But I wrote a 5-star review ~ in 2015 ??

• This reply was modified 2 years, 2 months ago by kirpich1.
• This reply was modified 2 years, 2 months ago by kirpich1.

ah, didn’t check ?? thanks for the 5 stars!

@optimizingmatters, 3 April, 2016 y. I’m leaving the topic. A lot of work with SEO. Thanks for the plugin ??