Compatiblity Conflict

Hi there,

Thanks for the great plugin! It’s very well designed and coded and super useful!

I ran into an issue the other day and found a solution, but I had to hack the core plugin files to get things working right and wanted to share with the hopes that maybe you can help shed some light on the problem. The issue is that Favorites does not work on a page where the plugin script is loaded via https, and the page/post loaded was loaded via the opposite protocol. So far I can only confirm this issue on WP Engine, and it may have something to do with how they handle SSL for their sites, and I’ve reported the issue to them. But, I can also resolve the issue by modifying your plugin. Essentially the issue seems to be with line 105 in /app/Activation/Dependencies.php where admin-ajax.php is loaded via admin_url(). admin_url() can also take a argument of ‘relative’ and when this is used, the plugin scripts are loaded in whatever protocol the page/post was loaded allowing it to operate properly.

Now, I don’t know the implications of using ‘relative’ in admin_url(), but it works perfectly! Any thoughts or ideas?

Thanks!
– Jonah

https://www.ads-software.com/plugins/favorites/