• Resolved peter

    (@dewebbouwmeester)


    Hi,
    Apparently a conflict was introduced at about the time of the release of WP4.0 between wpmudev’s e-Newsletter (https://premium.wpmudev.org/project/e-newsletter/) plugin and the Black Studio TinyMCE Widget plugin.
    The e-Newsletter uses a TinyMCE instance in the theme customizer where the user can enter the newsletter content.
    As soon as Black Studio TinyMCE Widget is activated, the e-Newsletter’s content area misses it’s TinyMCE functionality and becomes unuseable altogether.
    This behavior can be seen on a WP 4.0 installation with only the two mentioned plugins and the Twenty Fourteen theme. Both plugins are at their latest versions: Black Studio TinyMCE Widget v2.1.6, e-Newsletter v2.7.0.5.

    It looks like TinyMCE Widget should not load when the customizer is used in the way it is by e-Newsletter. Possibly this could be fixed by hooking into filter black_studio_tinymce_enable and return false when the e-Newsletter is being edited as part of the compatibility class.

    Please advice.

    https://www.ads-software.com/plugins/black-studio-tinymce-widget/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Marco Chiesi

    (@marcochiesi)

    Hi Peter,
    Unfortunately the e-Newsletter plugin is commercial and I don’t own a license for it. If you or the plugin developer can provide a copy of the plugin for testing purposes, I’d be glad to take a look and hopefully find a solution for the conflict. Otherwise an admin access to a site where the plugin is installed could be sufficient. You may send us a private message using our contact form or email.

    P.S. The black_studio_tinymce_enable wouldn’t be a good solution, as it totally prevents the TinyMCE widget from loading.

    Thread Starter peter

    (@dewebbouwmeester)

    Hello Marco,
    Thanks for your quick response. I will see what is possible in terms of access and will get back to you.
    In the meantime: The e-Newsletter sets up a completely seperate environment in the theme customizer, with one of its own themes. When editing the newsletter content, the TinyMCE widget is not used at all (or at least not in the theme I looked at) and not loading does seem safe under those conditions.
    But let me first try and see if you can get access somehow.
    Kind regards,
    Peter

    Plugin Author Marco Chiesi

    (@marcochiesi)

    Hi Peter,
    could you provide the URL structure of the e-Newsletter Customizer screen? If it’s totally separated the enable filter could be a viable solution.

    Thread Starter peter

    (@dewebbouwmeester)

    Hi Mario,
    That would be
    /wp-admin/customize.php?wp_customize=on&theme=iletter&newsletter_id=7&return=admin.php%3Fpage%3Dnewsletters
    The temp workaround i’m trying to use, checks for the customizer to be active and query var newsletter_id. This does seem to meet our requirements right now but I don’t know if there could be a newsletter theme that uses widgets.

    I’ve asked for granting you access to either code or install and will let you know asap.

    Plugin Author Marco Chiesi

    (@marcochiesi)

    Hi there,
    I did a debug session and I found the reason of the conflict. The easiest way to fix it, is to modify the e-Newsletter plugin and add a parameter on the editor initialization.
    Open the file e-newsletter/email-newsletter-files/builder/class.tinymce-control.php and change

    $tinymce_options = array(
    			'teeny' => false,
    			'media_buttons' => true,
    			'quicktags' => false,
    			'textarea_rows' => 25,
    			'drag_drop_upload' => true,
    			'tinymce' => array(
    				'theme_advanced_disable' => '',
    				'theme_advanced_buttons1_add' => 'code',
    				'theme_advanced_resize_horizontal' => true,
    				'add_unload_trigger' => false,
    				'resize' => 'both'
    			),
    			'editor_css' => '<style type="text/css">body { background: #000; }</style>',
    		);

    by adding 'wp_skip_init' => false, as follows

    $tinymce_options = array(
    			'teeny' => false,
    			'media_buttons' => true,
    			'quicktags' => false,
    			'textarea_rows' => 25,
    			'drag_drop_upload' => true,
    			'tinymce' => array(
    				'wp_skip_init' => false,
    				'theme_advanced_disable' => '',
    				'theme_advanced_buttons1_add' => 'code',
    				'theme_advanced_resize_horizontal' => true,
    				'add_unload_trigger' => false,
    				'resize' => 'both'
    			),
    			'editor_css' => '<style type="text/css">body { background: #000; }</style>',
    		);

    Please forward this to the e-Newsletter dev.

    Thread Starter peter

    (@dewebbouwmeester)

    Hi Marco,
    Thank you for your quick response.
    I’ve tested the fix and it does indeed bring back control over the email content area. However, html markup in the content is no longer properly processed, i.e. the markup is shown in stead of being applied after saving the newsletter and starting a new edit session of this same newsletter.
    So, when I create a newsletter and save it, then come back to edit it, all html markup is shown. Saving and editing once more further invalidates the markup.
    Can you reproduce this behavior? Any ideas?

    Plugin Author Marco Chiesi

    (@marcochiesi)

    Hi Peter,
    this other issue was already fixed in my dev version, so I didn’t notice it. I confirm that I was able to reproduce it by reverting to the 2.1.6 stable version. I just published the new version 2.2.0 now, and it shouldn’t have issues. Please take a test and confirm.

    Thread Starter peter

    (@dewebbouwmeester)

    Great Marco!
    I can confirm that it all works as expected in my dev setup with your latest version. I’ll forward the fix you suggest above to the e-newsletter team and will mark this topic as solved.
    Thank you for taking action this quick!

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Conflict with e-Newsletter’ is closed to new replies.