• Resolved Robert Trevellyan

    (@trevellyan)


    When the Jetpack Carousel module is enabled, metadata extracted from the original image is added to the markup for every image, as JSON, like this example:
    data-image-meta="{"aperture":"10","credit":"","camera":"Canon EOS REBEL T5","caption":"","created_timestamp":"1531865537","copyright":"","focal_length":"13","iso":"100","shutter_speed":"0.008","title":"","orientation":"1"}"

    A problem occurs when the copyright owner includes their email address in the copyright field. WP Mailto Links makes the JSON invalid, which breaks the HTML structure of the page, resulting in ugly text and layout problems in the browser.

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Ironikus

    (@ironikus)

    Hey @trevellyan – thank you a lot for your message.
    I just pushed a new version that also offers support for the Jetpack carousel. You should now be able to also use it without any issues.
    If you have any other questions, please let me know. ??

    Thread Starter Robert Trevellyan

    (@trevellyan)

    Thanks for pushing out a new version so soon. Unfortunately I’m still seeing problems on this site.

    What do you think of having an option to ignore emails in JSON?

    Plugin Author Ironikus

    (@ironikus)

    Hey @trevellyan – thanks for your message!
    That’s strange, I tested that upfront with your exact same logic as well.

    I checked your site again and I can’t see any scripts or styles loaded.
    Do you maybe use a plugin to minify files?
    Could you please also tell me how you currently protect this content area?
    To you use shortcodes somewhere or only the default settings?
    Thanks already a lot.

    Thread Starter Robert Trevellyan

    (@trevellyan)

    There is no minification involved.

    I’m not sure what you mean by “how you currently protect this content area?” The plugin is set to “Full-page scan” and “automatically the best method (including javascript)”. In fact, the only non-default setting is to turn off marketing notifications. I tried the “excluding javascript” setting but it didn’t help.

    We are not using any shortcodes for mailto links.

    I think it’s important to understand that with Jetpack Carousel active, every image gets a data-image-meta JSON block, regardless of whether there’s a gallery on the page or post. In this specific example, the images are output from a Toolset Views template, but all the other images on the site have a data-image-meta JSON block too. It just happens that on this page (the SOLD listings page) there are a few images that have an email address in the copyright field. I don’t think any other images do, and I haven’t noticed the problem on any other pages.

    Here’s how the first problematic data-image-meta block appears on the page with the plugin disabled:
    data-image-meta="{"aperture":"8","credit":"Robert Simmons","camera":"NIKON D750","caption":"","created_timestamp":"1532332950","copyright":"[email protected] *<m (207)-206-2828","focal_length":"50","iso":"280","shutter_speed":"0.004","title":"","orientation":"1"}"

    Plugin Author Ironikus

    (@ironikus)

    Hey @trevellyan – thanks a lot for your detailed message!
    I was able to figure it out. The issue was that we only checked against one instance of the preg match and not against all.
    I will push a fix for that with our next version.
    For now, we created a beta version for you with the exact fix. You can download it here: https://www.dropbox.com/s/qlf152ke0k2zrvg/wp-mailto-links_beta.zip?dl=1
    In case it should still not work (What I doubt), feel free to reach out again! ??

    Thread Starter Robert Trevellyan

    (@trevellyan)

    The beta version has resolved the problem.

    Thanks!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘conflict with Jetpack Carousel’ is closed to new replies.