• Resolved rokesmith

    (@rokesmith)


    Hello,

    Thanks for the great popup plugin.

    The plugin works great on the theme I am using (Jumpstart) but I have an issue when I have used the modal popup built into the theme. It seems like Popup Maker is interfering with those other popups. Is there a workaround? Here is the code on my site with Popup Maker disabled:

    <div class="video-download-section row">
    	<div class="col-sm-6">
    		<p>
    		<a href="#popup_8317140835cc9530f045fe" title="Download Video" class="btn btn-default" target="_self" data-toggle="modal">Download Video</a>
    		</p>
    	</div>
    	<div class="col-sm-6 text-right">
    		<p>
    		<a href="#popup_1026969325cc9530f049d5" title="Add to My Videos" class="btn btn-default" target="_self" data-toggle="modal">Add to My Videos</a>
    		</p>
    	</div>
    </div>

    After enabling Popup Maker the same section becomes:

    <div class="video-download-section row">
                                                            <div class="col-sm-6">
                                                                <div id="pum--54772" class="pum pum-overlay pum-theme-556823 pum-theme-default-theme popmake-overlay click_open" data-popmake="false" role="dialog" aria-hidden="true">
                                                                    <div id="popmake--54772" class="pum-container popmake theme-556823">
                                                                        <div class="pum-content popmake-content">
                                                                            <p>I understand that by downloading these files:</p>
                                                                            <p>1. I will not be able to ask for a refund after I have downloaded any files.</p>
                                                                            <p>2. I agree that I will never upload these files to any video or file sharing websites.</p>
                                                                            <p>3. I understand that I may show the files in my own home to family and friends, and that I may use them myself, but I will not show them in public or give or share the files themselves with anyone.</p>
                                                                            <hr/>
                                                                            <p>
                                                                                <em>
                                                                                    <strong>By clicking any of the buttons below you signify that you understand and agree to the above.</strong>
                                                                                </em>
                                                                            </p>
                                                                            <hr/>
                                                                            <div class="alert alert-success">You have 12 credits left. Downloading this video or adding it to your ‘My Videos ’library will reduce your credits by 1. Downloading videos also automatically adds them to your ‘My Videos ’library where you can view or download them as many times as you wish.</div>
                                                                            <!-- .alert (end) -->
                                                                            <p>
                                                                                <a class="btn btn-primary download-video" target="_blank" title="Garden Bench: Episode 1 360p" href="https://player.vimeo.com/play/1291832253?s=329291868_1556738855_3ef209ff7b00f5b95e7320c1cf3d22d1&loc=external&context=Vimeo%5CController%5CApi%5CResources%5CUser%5CVideoController.&download=1&filename=Garden%2BBench%2BEpisode%2B1164.mp4" download="Garden Bench: Episode 1 SD">Garden Bench: Episode 1 360p</a>
                                                                                This is the lower resolution and is 188 MB.
                                                                            </p>
                                                                            <p>
                                                                                <a class="btn btn-primary download-video" target="_blank" title="Garden Bench: Episode 1 720p" href="https://player.vimeo.com/play/1291832256?s=329291868_1556738855_5743c0f7ee59a05a8e61513a7b5c0647&loc=external&context=Vimeo%5CController%5CApi%5CResources%5CUser%5CVideoController.&download=1&filename=Garden%2BBench%2BEpisode%2B1174.mp4" download="Garden Bench: Episode 1 HD">Garden Bench: Episode 1 720p</a>
                                                                                This is the higher resolution and is 697 MB.
                                                                            </p>
                                                                        </div>
                                                                        <button type="button" class="pum-close popmake-close" aria-label="Close">×</button>
                                                                    </div>
                                                                </div>
                                                                <script type='text/javascript' id='pum-move-popup--54772'>
                                                                    jQuery(document).ready(function() {
                                                                        jQuery('#pum--54772').appendTo('body');
                                                                        window.pum_vars.popups['pum--54772'] = {
                                                                            "disable_on_mobile": false,
                                                                            "disable_on_tablet": false,
                                                                            "custom_height_auto": true,
                                                                            "scrollable_content": false,
                                                                            "position_from_trigger": false,
                                                                            "position_fixed": false,
                                                                            "overlay_disabled": false,
                                                                            "stackable": false,
                                                                            "disable_reposition": false,
                                                                            "close_on_overlay_click": false,
                                                                            "close_on_esc_press": true,
                                                                            "close_on_f4_press": false,
                                                                            "disable_form_reopen": false,
                                                                            "disable_accessibility": false,
                                                                            "disable_analytics": true,
                                                                            "theme_id": "556823",
                                                                            "size": "default",
                                                                            "custom_width": "",
                                                                            "custom_width_unit": "px",
                                                                            "custom_height": "",
                                                                            "custom_height_unit": "px",
                                                                            "location": "center top",
                                                                            "position_top": "100",
                                                                            "position_left": "0",
                                                                            "position_bottom": "0",
                                                                            "position_right": "0",
                                                                            "animation_type": "fade",
                                                                            "animation_speed": "1000",
                                                                            "animation_origin": "top",
                                                                            "triggers": [{
                                                                                "type": "click_open",
                                                                                "settings": {
                                                                                    "extra_selectors": "#popmake-"
                                                                                }
                                                                            }],
                                                                            "id": "-54772",
                                                                            "slug": ""
                                                                        };
                                                                        window.pum_popups['pum--54772'] = {
                                                                            "disable_on_mobile": false,
                                                                            "disable_on_tablet": false,
                                                                            "custom_height_auto": true,
                                                                            "scrollable_content": false,
                                                                            "position_from_trigger": false,
                                                                            "position_fixed": false,
                                                                            "overlay_disabled": false,
                                                                            "stackable": false,
                                                                            "disable_reposition": false,
                                                                            "close_on_overlay_click": false,
                                                                            "close_on_esc_press": true,
                                                                            "close_on_f4_press": false,
                                                                            "disable_form_reopen": false,
                                                                            "disable_accessibility": false,
                                                                            "disable_analytics": true,
                                                                            "theme_id": "556823",
                                                                            "size": "default",
                                                                            "custom_width": "",
                                                                            "custom_width_unit": "px",
                                                                            "custom_height": "",
                                                                            "custom_height_unit": "px",
                                                                            "location": "center top",
                                                                            "position_top": "100",
                                                                            "position_left": "0",
                                                                            "position_bottom": "0",
                                                                            "position_right": "0",
                                                                            "animation_type": "fade",
                                                                            "animation_speed": "1000",
                                                                            "animation_origin": "top",
                                                                            "triggers": [{
                                                                                "type": "click_open",
                                                                                "settings": {
                                                                                    "extra_selectors": "#popmake-"
                                                                                }
                                                                            }],
                                                                            "id": "-54772",
                                                                            "slug": ""
                                                                        };
                                                                        jQuery('#pum-move-popup--54772').remove();
                                                                    });
                                                                </script>
                                                            </div>
                                                            <div class="col-sm-6 text-right">
                                                                <div id="pum--94865" class="pum pum-overlay pum-theme-556823 pum-theme-default-theme popmake-overlay click_open" data-popmake="false" role="dialog" aria-hidden="true">
                                                                    <div id="popmake--94865" class="pum-container popmake theme-556823">
                                                                        <div class="pum-content popmake-content">
                                                                            <div class="alert alert-success">You have 12 credits left. Adding this video to ‘My Videos’ will reduce your credits by 1. After adding it you can then download or view the video as many times as you wish.</div>
                                                                            <!-- .alert (end) -->
                                                                            <p>
                                                                                <a href="#" title="Confirm" class="btn btn-default add-to-my-videos" target="_self">Confirm</a>
                                                                            </p>
                                                                        </div>
                                                                        <button type="button" class="pum-close popmake-close" aria-label="Close">×</button>
                                                                    </div>
                                                                </div>
                                                                <script type='text/javascript' id='pum-move-popup--94865'>
                                                                    jQuery(document).ready(function() {
                                                                        jQuery('#pum--94865').appendTo('body');
                                                                        window.pum_vars.popups['pum--94865'] = {
                                                                            "disable_on_mobile": false,
                                                                            "disable_on_tablet": false,
                                                                            "custom_height_auto": true,
                                                                            "scrollable_content": false,
                                                                            "position_from_trigger": false,
                                                                            "position_fixed": false,
                                                                            "overlay_disabled": false,
                                                                            "stackable": false,
                                                                            "disable_reposition": false,
                                                                            "close_on_overlay_click": false,
                                                                            "close_on_esc_press": true,
                                                                            "close_on_f4_press": false,
                                                                            "disable_form_reopen": false,
                                                                            "disable_accessibility": false,
                                                                            "disable_analytics": true,
                                                                            "theme_id": "556823",
                                                                            "size": "default",
                                                                            "custom_width": "",
                                                                            "custom_width_unit": "px",
                                                                            "custom_height": "",
                                                                            "custom_height_unit": "px",
                                                                            "location": "center top",
                                                                            "position_top": "100",
                                                                            "position_left": "0",
                                                                            "position_bottom": "0",
                                                                            "position_right": "0",
                                                                            "animation_type": "fade",
                                                                            "animation_speed": "1000",
                                                                            "animation_origin": "top",
                                                                            "triggers": [{
                                                                                "type": "click_open",
                                                                                "settings": {
                                                                                    "extra_selectors": "#popmake-"
                                                                                }
                                                                            }],
                                                                            "id": "-94865",
                                                                            "slug": ""
                                                                        };
                                                                        window.pum_popups['pum--94865'] = {
                                                                            "disable_on_mobile": false,
                                                                            "disable_on_tablet": false,
                                                                            "custom_height_auto": true,
                                                                            "scrollable_content": false,
                                                                            "position_from_trigger": false,
                                                                            "position_fixed": false,
                                                                            "overlay_disabled": false,
                                                                            "stackable": false,
                                                                            "disable_reposition": false,
                                                                            "close_on_overlay_click": false,
                                                                            "close_on_esc_press": true,
                                                                            "close_on_f4_press": false,
                                                                            "disable_form_reopen": false,
                                                                            "disable_accessibility": false,
                                                                            "disable_analytics": true,
                                                                            "theme_id": "556823",
                                                                            "size": "default",
                                                                            "custom_width": "",
                                                                            "custom_width_unit": "px",
                                                                            "custom_height": "",
                                                                            "custom_height_unit": "px",
                                                                            "location": "center top",
                                                                            "position_top": "100",
                                                                            "position_left": "0",
                                                                            "position_bottom": "0",
                                                                            "position_right": "0",
                                                                            "animation_type": "fade",
                                                                            "animation_speed": "1000",
                                                                            "animation_origin": "top",
                                                                            "triggers": [{
                                                                                "type": "click_open",
                                                                                "settings": {
                                                                                    "extra_selectors": "#popmake-"
                                                                                }
                                                                            }],
                                                                            "id": "-94865",
                                                                            "slug": ""
                                                                        };
                                                                        jQuery('#pum-move-popup--94865').remove();
                                                                    });
                                                                </script>
                                                            </div>
                                                        </div>

    It seems like Popup Maker is claiming the popup and adding its scripts and styling but since it isn’t a Popup Maker popup I am ending up with a visual mess and can only resolve it by disabling Popup Maker.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter rokesmith

    (@rokesmith)

    We figured it out.

    The theme was using the shortcode [popup] Content [/popup] and Popup Maker uses the same shortcode. We managed to rename the theme shortcodes and the conflict is resolved.

    Plugin Author Daniel Iser

    (@danieliser)

    @rokesmith – Strange, first I’ve seen any other plugin use that shortcode in the past 5 years.

    Glad you got it worked out.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Conflict with theme popups’ is closed to new replies.