• Resolved hrsms

    (@hrsms)


    I was really having fun adding glossary items using this plugin, until I discovered the conflict with MetaSlider, on which I am already relying on heavily. I should have checked that my site was still working before spending all those hours on glossary items! That’s on me. But I hope you can fix this.
    The page I linked to is one of many on my site that uses MetaSlider. I have your plugin disabled, so I doubt this will be helpful.

    • This topic was modified 4 years, 2 months ago by hrsms.

    The page I need help with: [log in to see the link]

Viewing 14 replies - 1 through 14 (of 14 total)
  • Plugin Author CreativeMindsSolutions

    (@creativemindssolutions)

    Can you describe what is the issue when activating our plugin

    Is it happening on all pages on your sites or only those which has MetaSlider

    Thread Starter hrsms

    (@hrsms)

    It only affects pages using MetaSlider, and those pages render exactly as expected except that the MetaSlider is not displayed. For example, on the example page, you would see the Featured Image, some text rendered by a Pods template (who built the model and a bunch of categories) and then a series of headers and paragraphs (‘About the Vessel’, ‘Culé’, ‘Chata’, ‘About the Model’, ‘Model Images’). After ‘Model Images’ you see the MetaSlider. But when your plugin is activated this does not appear. Everything else stays the same – only the MetaSlider is missing.

    Plugin Author CreativeMindsSolutions

    (@creativemindssolutions)

    It could be an HTML issue with MegaSlider

    My suggestion
    1 – deactivate our plugin
    2 – run n HTML validator check on the page which has this issues https://validator.w3.org/
    3 – deactivate MegaSlider again an do the same

    Find our which HTML issue MegaSlider creates

    Thread Starter hrsms

    (@hrsms)

    I did the test you suggested and two others.
    I also tried using the WordPress 2020 theme instead of Sydney. That did not change anything.

    =======================

    Test 1 / State A – CM Tooltips Off, MetaSlider Off
    Test 1 / State B – CM Tooltips Off, MetaSlider On

    There are two additional warnings for MetaSlider

    Warning: The type attribute is unnecessary for JavaScript resources.
    From line 682, column 1; to line 682, column 189
    </script>?<script type=’text/javascript’ src=’https://www.hrsms.org/Content/wp-content/plugins/ml-slider/assets/sliders/flexslider/jquery.flexslider.min.js?ver=3.18.0&#8242; id=’metaslider-flex-slider-js’></scri

    Warning: The type attribute is unnecessary for JavaScript resources.
    From line 683, column 1; to line 683, column 68
    </script>?<script type=’text/javascript’ id=’metaslider-flex-slider-js-after’>?var m

    =======================

    Test 2 / State A – CM Tooltips Off, MetaSlider On
    Test 2 / State B – CM Tooltips On, MetaSlider On

    There are two additional warnings for CM Tooltips

    Warning: The type attribute is unnecessary for JavaScript resources.
    From line 127, column 1; to line 127, column 56
    </script>?<script type=’text/javascript’ id=’tooltip-js-js-extra’>?/* <!

    Warning: The type attribute is unnecessary for JavaScript resources.
    From line 132, column 1; to line 132, column 170
    </script>?<script type=’text/javascript’ src=’https://www.hrsms.org/Content/wp-content/plugins/enhanced-tooltipglossary/frontend/assets/js/tooltip.js?ver=5.5.1&#8242; id=’tooltip-js-js’></scri

    =======================

    Test 3 / State A – CM Tooltips Off, MetaSlider Off
    Test 3 / State B – CM Tooltips On, MetaSlider Off

    There are two additional warnings for CM Tooltips (same as when both are on)

    Warning: The type attribute is unnecessary for JavaScript resources.
    From line 127, column 1; to line 127, column 56
    </script>?<script type=’text/javascript’ id=’tooltip-js-js-extra’>?/* <!

    Warning: The type attribute is unnecessary for JavaScript resources.
    From line 132, column 1; to line 132, column 170
    </script>?<script type=’text/javascript’ src=’https://www.hrsms.org/Content/wp-content/plugins/enhanced-tooltipglossary/frontend/assets/js/tooltip.js?ver=5.5.1&#8242; id=’tooltip-js-js’></scri

    • This reply was modified 4 years, 2 months ago by hrsms.
    • This reply was modified 4 years, 2 months ago by hrsms.
    Plugin Author CreativeMindsSolutions

    (@creativemindssolutions)

    Hi,

    The warnings are not related to the issue this is just an information about the type=”text/javascript” which can be omitted in HTML5.

    Please try to wrap the metaslider code with [glossary_exclude][/glossary_exclude] to exclude it from being parsed.

    Thread Starter hrsms

    (@hrsms)

    That is a good workaround, and I’m ashamed it did not occur to me, as I’m using glossary_exclude elsewhere.

    When you say “wrap the metaslider code”, where you referring to shortcodes (e.g. [glossary_exclude][metaslider id=”####”][/glossary_exclude] ), or where you suggesting that I customize the MetaSlider PHP and/or Java code?

    If the latter, I am avoiding any code changes whatsoever on my site. Though I am a programmer by profession, I am not a WordPress programmer, and I work with C++ and C#, not PHP or Java. It might be fun to learn WordPress programming, but it is not near the top of my to-do list at the moment ??
    More importantly, my site is just for a club, and at some point it will be handed off to someone else to manage, and that person will likely not be a programmer at all.

    If you just meant the shortcodes, I can certainly do that. But your persistence in this matter would be appreciated. MetaSlider has their own block, and I would prefer to use that in place of the Shortcode block, which is required for this workaround. It is not a critical issue, but it would make for more straightforward page creation, for myself or whoever eventually takes over from me. Perhaps you can work with the folks at MetaSlider?

    Thanks.

    Hi @hrsms,

    Can you activate CM Tooltip Glossary now and let me see the example page in a broken state? I’ll be online for the next two hours and can take a look as soon as you say it’s ready.

    – Kevin (from MetaSlider)

    Thread Starter hrsms

    (@hrsms)

    Thank you for continuing to look at this.

    CM Tooltip is active now.

    The example page
    https://www.hrsms.org/Content/model/cule-and-chata/
    does not have the glossary_exclude shortcode added, and is broken.

    For an example of the glossary_exclude shortcode included as a successful workaround, see https://www.hrsms.org/Content/model/balao-uss-ss-285/

    Let me know if including URLs in these messages is forbidden and I’ll edit the reply.

    Your post is fine.

    Yeah, I don’t see MetaSlider at all on there anymore. As if the whole thing crashes. You will probably have a PHP error in your server logs. You might have to enable debug mode though. You can do that by following a guide, such as this one:

    https://wp-staging.com/docs/enable-wordpress-debug-log-mode/

    (from the guide, you might be able to set the display option to true instead, and see the error on the screen.)

    Thread Starter hrsms

    (@hrsms)

    I enabled debug mode and saw two errors, one of which I cannot replicate.

    The first was:
    WP_User->id was called with an argument that is deprecated since version 2.1.0! Use WP_User->ID instead. in /home3/hrsmsorg/public_html/Content/wp-includes/functions.php on line 5057

    But it is not related to either plugin (yours or MetaSlider) and appears whether or not your plugin is enabled.

    The second was related to register_rest_route being used incorrectly. I searched all of the files, and MetaSlider is the only plugin I am using that calls it. But this error no longer appears whether or not your plugin is enabled. Whether or not I am using the glossary_exclude workaround also makes no difference with regard to this error.

    When I did see the error, I cannot recall whether your plugin was enabled. I presume it was not – that MetaSlider only executes this code and causes the error when your plugin is disabled.

    It appears to me that your parsing of the page must be the source of the problem. Can you add the MetaSlider plugin to a test site and step through the execution of your code?

    Thanks,

    Greg

    Plugin Author CreativeMindsSolutions

    (@creativemindssolutions)

    Hi Greg,

    We’ve done some local testing on a page running both Metaslider and our terms and there were no visual issues. We’ve seen the “register_rest_route” issue in the debug.log but like you’ve noticed it’s not coming from our plugin and it doesn’t seem to create any issue for our plugin.

    Maybe you can contact us at support ‘at’ cminds.com and share the credentials for the site you need help with, so we can try to catch the bug? (Perhaps there’s a third party plugin/theme involved)

    Thread Starter hrsms

    (@hrsms)

    Email sent. Thanks.

    Thread Starter hrsms

    (@hrsms)

    I’ve found the solution.

    Your last reply mentioned the possibility of interference from a plugin other than MetaSlider or CM Tooltip Glossary. At the beginning, I had disabled all the plugins I could and used the standard WordPress theme. Yet I still saw the issue.

    I think the only plugin other than MetaSlider and CM Tooltip Glossary that I left enabled was Pods. I did not disable Pods since the failure occurs on a custom post-type created using Pods, and I didn’t see how I could test it otherwise. As simple as it is, it had not occurred to me to create a test page that does not use Pods in order to rule it out as the culprit. I’ve just done so, and you are correct – there is no problem when not using Pods.

    Actually, it also works with Pods when the post is not rendered using a Pods Template. When I disabled the template I was using the problem went away. So now the problem is narrowed down to the template.

    The template can replace the content or be displayed before or after the content.
    I was replacing the content, which means that in order to get the content displayed the template had to end with {@post_content}. So one solution was to change to displaying the template before the content and eliminate this line.

    That resolved the problem but the solution prevents me from having template content both before and after the post content:

    This is template content
    This is more template content
    {@post_content}
    Conclude with more template content

    After a little searching I stumbled upon the better solution.

    Jory Hogeveen (@keraweb)
    9 months, 1 week ago
    I did some more digging and found a possible solution with Pods Templates.

    {@post_content} always returns the raw content from the object. This isn’t parsed by any filters or functions.

    However, the function get_the_content() properly filters and parsed the content of an object and only required an object ID as the parameter.

    So instead of {@post_content} you could do this: {@ID,get_the_content}

    So I can continue to replace the content and instead have the template end with {@ID,get_the_content} and everything is working fine, without using [glossary_exclude]. The MetaSlider block is also working.

    I appreciate they time you took to help me.

    Regards,

    Greg

    • This reply was modified 4 years, 1 month ago by hrsms.
    • This reply was modified 4 years, 1 month ago by hrsms.
    • This reply was modified 4 years, 1 month ago by hrsms.
    Plugin Author CreativeMindsSolutions

    (@creativemindssolutions)

    Hi Greg,

    I’m happy that you’ve figure it out and thank you very much for sharing your findings with us and other users of CM Tooltip Glossary!

Viewing 14 replies - 1 through 14 (of 14 total)
  • The topic ‘Conflicts with MetaSlider’ is closed to new replies.