Content Social Image skips first image

  • Resolved daxelrod

    (@daxelrod)


    3 years, 5 months ago

    SEO Framework version 4.1.5.1

    In autodescription/inc/classes/builders/images.class.php:get_content_image_details():

    
for ( $i = 0; $i++ < static::MAX_CONTENT_IMAGES; ) {
	// Fewer than MAX_CONTENT_IMAGES matched.
	if ( ! isset( $matches[ $i ][2] ) ) break;

    The first image in the page content is ignored due to the incrementing of $i when it checks the condition $i++ < static::MAX_CONTENT_IMAGES;. I couldn’t find any documentation suggesting this was the intended behavior, so I have to believe it’s a bug and should be rewritten as for ( $i = 0; $i < static::MAX_CONTENT_IMAGES; $i++ ) {.

Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
  • The topic ‘Content Social Image skips first image’ is closed to new replies.