• Resolved dblomster

    (@dblomster)


    Hello,

    I’ve done some further testing with Woocommerce Products Per Page v1.0.7.

    1. The plugin handles the number of products correctly while having the options 12 (default setting) and all. But if I add more options in between such as 24 & 48, it’ll jump back to show 12 products after going to the next page.

    2. I get an error when trying to list products by product tag so actually the whole page breaks. The error message is: “Catchable fatal error: Object of class WP_Error could not be converted to string in /path/to/wp-content/plugins/woocommerce-products-per-page/objects/wppp-dropdown.php on line 32”.

    3. I believe the dropdown should only be shown in cases when there are products to display. I could fix this by first checking with the function woocommerce_products_will_display(). Maybe you should add it as well?

    Again, thanks for your hard work on this useful plugin!

    https://www.ads-software.com/plugins/woocommerce-products-per-page/

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Jeroen Sormani

    (@sormano)

    Hi dblomster,

    Thanks for sharing these points.

    1. Could you post your website/ send it to me by my website?
    1.1 What theme/woocommerce version do you use?
    2. I will fix this with the next update (probably this weekend)
    3. Thanks for sharing, I will also look into this.

    Plugin Author Jeroen Sormani

    (@sormano)

    Just released an update with fix/tweak for points 2 and 3 ??

    Thread Starter dblomster

    (@dblomster)

    Thanks for the update!

    1. I’m running the latest WP/Woo version with a custom theme locally . But I guess this issue should be checked on a standard WP/Woo installation with the default theme as well. Perhaps I’ll be able to set it up within the next few days. Also, if you need any debug output, or variable dumps or such, let me know.

    2. Seems all right at first glance, great ??

    3. This one didn’t work in my setup, so I putted in this code in the public function wppp_create_object:
    if ( ! woocommerce_products_will_display() ) { return; }

    Plugin Author Jeroen Sormani

    (@sormano)

    Let me know when you checked with default theme. I’m running my tests on multiple themes, but mainly default wich works fine.

    The plugin uses WooCommerce sessions to save the user input, maybe that doesn’t save on you machine? (do you products stay in your cart when switching pages?)

    I will look further in point 3, after doing some further testing this does not seem to work always.

    Thread Starter dblomster

    (@dblomster)

    Interesting about sessions! Actually, I don’t use the cart, all products are of the type External/Affiliate.

    Var dumps of $woocommerce->session->products_per_page reveal that the number of products is set after drop-down selection and then becomes NULL when going to the next page.

    Maybe what’s discussed here -> https://github.com/woothemes/woocommerce/issues/4920 <- could be related to the issue I’m seeing?

    What do you think?

    Plugin Author Jeroen Sormani

    (@sormano)

    That issue seems related, just tested with icognito tab with Woo 2.1.5 and it indeed did not save the ppp on just this case.

    I will look into this a.s.a.p. and get back to you.

    Plugin Author Jeroen Sormani

    (@sormano)

    Just released 1.0.9 with improvement for 2.1.X wich saves the PPP when the cart is empty and improvement for displaying the dropdown on pages with products.

    Let me know how this works for you (and others..)

    Thread Starter dblomster

    (@dblomster)

    Seems like you nailed it this time! Fantastic achievement!

    I’ll be moving my site to production soon and will let you know if any issues should arise.

    Might be a good time to add a donation link for this plugin ??

    Plugin Author Jeroen Sormani

    (@sormano)

    Hi dblomster,

    Thanks, comments like this motivates me to continue ??

    Just added a donate link to the plugin/my website (https://www.jeroensormani.nl/donate/)

    definitely not required but surely appreciated ??

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Couple of issues’ is closed to new replies.