Coupon not sent if other items in order

  • Resolved sjmiddleton

    (@sjmiddleton)


    4 years, 3 months ago

    Hi,

    I have discovered what seems to be a bug in PDF Coupons.

    If I set the coupons to be automatically generated and sent on Processing and then create an order a non-coupon item and a coupon then the coupon is not generated and sent. Note the order is important.

    If I create an order with just a coupon, then the coupon is sent as expected.

    The problem seems to be in the function CouponsProcessing::generate_coupons_for_order_items()

    It iterates over the items in the order and if the item is for a coupon then it creates it.

    However if the item is not a coupon then it throws an exception. This means that the iteration stops at this point, and any further items are not inspected. So if the coupon is not the first item in the order it is not processed.

    Thanks,
    Simon.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support tomasz_bednarek

    (@tomasz_bednarek)

    Hi Simon,

    thank you for your message!

    I will inform about the issue our programmer to check it/ optimize the code.

    Thank you for reporting the issue. I will inform you as soon as the update is ready.

    Meanwhile, if you have any questions let me know.

    Best regards,

    @sjmiddleton

    Plugin Support tomasz_bednarek

    (@tomasz_bednarek)

    Hi Simon,

    I wanted to inform you that the 1.2.0 version of the plugin is ready.
    Please update the plugin and let me know if everything is working properly.

    Best regards,

    Thread Starter sjmiddleton

    (@sjmiddleton)

    Hi Tomasz,

    I’ve tested the 1.2.0 plugin and your fix appears to be working correctly.

    Many thanks,
    Simon.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Coupon not sent if other items in order’ is closed to new replies.