CSS Issues

Hi @dbareis

I hope you’re well today!

Thank you for your feedback but I’m not quite sure if I understand the goal here.

The way this is supposed to work by design is:

1. if the option to apply custom formatting on broken links is not enabled, plugin by default do not modify CSS of the site and that would/should mean links presentation is not altered in any way

2. if you tick that option, the class would be added to mark them

3. if you “untick” it, that class would be removed and that should work just fine unless there’s some caching applied that keeps the class still added in cached version of the page.

Using “!important” isn’t an “elegant” solution and is never recommended unless absolutely necessary and in this case it should not be necessary.

So do I correctly understand that the links on your site are marked correctly as broken if the option is enabled but if it’s disabled – they stay marked as broken and that’s why you want to use “!important”, to revert that change?

If so, that shouldn’t be necessary and instead either cache should be cleared or the optimized CSS of page should be regenerated (depending on what caused it to be “cached”).

Or am I missing the point here?

Kind regards,
Adam

Hi Adam, @wpmudev-support8

At the moment the plugin doesn’t seem to be working at all since I used the “re-check all pages” option (since there seems to be no way to unhide accidentally hidden (or other actions) URLs.

Anyway, the option says “Apply custom formatting to broken link” with an Edit CSS option, to me that means that it is your CSS that you are asking about (custom formatting). It says nothing about tagging the HTML (for that matter where are warnings tagged?). I have worked around this by adding empty css in the edit box.

Whether “!important” is elegant or not is meaningless when it is required. Whether it is required depends on how the site/page is structured.

Without “!important” your CSS did nothing to the error links, it only worked after adding it. There is no “caching” involved here, just me debugging why I didn’t see any changes (using the chrome debug console).

Hi @dbareis,

I checked this on a test website and could confirm the CSS added at “Apply custom formatting to broken link” is working fine without “!important”. I suspect that a CSS conflict is causing an issue at our end. Can you please share the CSS from your end so that we could take a closer look at this?

We look forward to hearing back from you.

Kind Regards,
Nebu John

CSS is everywhere you are better off using the chrome debug console or similar, this is the page: https://www.wcipp.org.au/useful-links/

The “Eucalypt key” is above the now disabled one that had the problem.

Hi @dbareis

Thanks for sharing this link.

The issue there is with “Pea key – Lucid”, right?

There is not Broken Link Checker class and CSS applied to that link currently. It is striked-out because it’s wrapped with HTML S tag .

This overrides Broken Link Checker link formatting and to remove that “strike-through” you either need “stronger” CSS or style the S tag directly or remove it.

But that tag doesn’t come form Broken Link Checker. Our plugin only adds a class but it doesn’t change markup other than this.

The S tag doesn’t come form Broken Link Checker so unless this was manually edited, it must be coming from some other plugin on site or some custom code. That tag, makes text always striked-through, regardless of whether BLC CSS is there or not so you’d need to look through any custom code that you may have possibly added to the site and/or through theme/other plugins’ options to find out what is adding it.

Kind regards,
Adam

Hi @dbareis,

Since we haven’t heard from you for a while. I’ll mark this thread as resolved for now. Please feel free to re-open the thread if you need further assistance.

Best Regards
Nithin