• Resolved Thierry

    (@theremingenieur)


    First of all, thank you very much and congratulations for this great plugin!

    Before I was aware of it, I tried to do some little tweaks with some rather clumsy custom css. Doing everything in the customizer is now much easier.

    You encourage everybody to send you feature request, so I will do that here. I sort them by priority:

    1. <b>Very important:</b> In content options, below “Hide Post Author”, please add “Hide Post Date”. I’m using a kind of hierarchical Category/Post structure to display pseudo static content on archive pages. No blogging – no date needed. ??
    2. <b>Important:</b> In content options, I’d like to be able to style the heading tags, at least h2, h3, and h4 in terms of size, weight, and color, similar to the nav menu options.
    3. <b>Nice to have, but not urgent:</b> As the Twenty Seventeen theme allows a static multi-page front page, a feature which I don’t yet use, I’d like the plugin to add automatically the needed anchor tags to allow to jump to a specific sub-page via the navigation menu, and optionally to add a little helper to create the needed anchor links in the menu.

    I understand that the last point might be relatively complex. I’m ready to pay the same upgrade price again to get that.

    The page I need help with: [log in to see the link]

Viewing 15 replies - 1 through 15 (of 40 total)
  • Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    Glad you like the plugin! And thanks for the feature requests!

    “Hide Post Date” should be possible to be done in a similar way to the “Hide Post Author”. We basically use WordPress’ translation engine to get rid of the text before it’s even translated let alone sent to the client. We’ll add this to the next update.

    Styling the title tags is also on our list so yes to this one too.

    With regards to your last feature request we are actually about to start development on this anyway as we are soon to build a site that does just that with Twenty Seventeen. We were going to add the anchor links into the menu as custom links to (for example) /#test but we can see how a helper would be useful and will try to think of a way to do this.

    Will update this thread when there’s an update for you to test ??

    Kind regards,

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    Just published an update that allows you to add more sections to the static front page and to include anchor links to them when editing your menus.

    Let me know what you think.

    Thanks,

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Thank you!

    In fact, I found the slider to adjust the number of front page sections. At the very first moment, I thought that it did not work until I understood that I had to click on publish, close the customizer, and open the customizer again to see the changes take effect.

    Afterwards, I feel a little dumb… Can’t see how to make a menu item from a front page section. Do I have to create a custom link with a #panel-1 anchor? Will try that now.

    I think that I am not a bad coder in C++ and assembly when it comes to make music on 32bit ARM CPUs. But this html/php/js stuff is definitively not my cup of tea…

    Edit: Works somehow with a link towards #panel1, but I don’t know if it’s my Safari browser or what, although the id=”panel1″ comes before the h2 class=”entry-header”, the browser scrolls too much forward that the header will already be hidden and the content be displayed on top of the page.

    Reverting everything temporarily for now until I have a better understanding of all that…

    • This reply was modified 6 years, 4 months ago by Thierry.
    Thread Starter Thierry

    (@theremingenieur)

    Just to prevent any misunderstandings (which are for sure on my side), I expected that to work like demonstrated here:

    https://wpcolt.com/create-one-page-website-using-twenty-seventeen-theme/

    Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    Yes, the front page section slider has to be saved and then the customiser reloaded because the setting directly changes the content of the customiser itself so we cannot see a way of easily making this work any other way.

    With regards to the Menu items …

    1) Go to Appearance -> Menus
    2) In the left hand “accordion” select “Front Page Sections” item to expand it
    3) Listed in here will be pages that you have selected in the Customiser as your front page sections
    4) Ticking the box next to the desired item and clicking on “Add to menu” will add the anchor link as a custom link to your menu

    You are correct that #panel1 doesn’t quite scroll far enough when there is a featured image to the title of the section so we are working on a jQuery method to inject ids into the <h2 class=”entry-title”> to link to instead.

    The smooth scrolling on the link you provided is also on our “to do” list.

    Kind regards,

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Ok, my fault, didn‘t look in the admin appearance menu because I thought everything was in the customized. Thank you for your patience with me. Besides the scrolling too far, it works fine now.

    Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    OK, I think all your requests should now have been dealt with on the update I’ve just uploaded.

    Please test and confirm.

    Many thanks,

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    I’m sad to say I found a few things which I can’t (yet) confirm…

    Hiding the post date works well in the single post view, but not on category pages, the date remains visible above each listed post, for example here: https://theremin.academy/teachers/

    For testing the one page navigation, I added one static page in front page section #1 and I replaced the page link in the main menu by the corresponding custom link /#panel1-title.
    When I’m already somewhere on the front page, clicking this custom link in the menu will jump to the top of the page which should not happen.
    When I’m on a different and independent page or post and click the same custom link in the menu, it jumps to the front page section, but still scrolls too far, the section page title is again hidden behind the header image, so no improvement from the last release.
    Had (again) to revert to the single page navigation, it’s a prod site and I unfortunately can’t allow to keep it malfunctioning to show and reproduce these errors.

    Another issue I discovered just now is the incompatibility with the WPML (multi-language) plugin which I use to maintain the site in English (default), French, and German. That’s not your fault, I have to see with them how I can get custom links rewritten depending on the actual language, so that if I’m for example on the German front page (https://theremin.academy/de/), the custom link would be automatically rewritten as /de/#panel1-title.

    Plugin Author Oliver Campion

    (@domainsupport)

    Hmmm, OK so I’ll have a look at the category pages to see how it differs in displaying the post date. That shouldn’t be a problem to fix.

    With regards to the issue you’ve found with regards to …

    – anchor links jumping to the top of the page
    – anchor links scrolling too far
    – incompatibility with WPML

    I’m going to need to see this in order to fix … although I have an idea for most of these.

    I’ll keep you posted.

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    In case you really can‘t reproduce some problems, we‘ll need to find and agree about a short ?demo“ time where I‘d turn everything on for a few minutes, so that you could have a look.

    Regarding the WPML issue, it‘s a general WP custom link problem, since these work basically with hard coded urls, so it’s not only about your anchor navigation. I will try to put that on the WPML developer’s shoulders, since I understand that I’m already eating ways too much of your precious time.

    Plugin Author Oliver Campion

    (@domainsupport)

    OK, so having had a quick look at that plugin, I can confirm that they do not parse custom links. I thought it might make a difference if we included the domain in the link (https://theremin.academy/#panel1-title rather than just /#panel1-title) but it doesn’t so yes, they will probably need to be contacted for that.

    I’ve not managed to replicate “anchor links jumping to the top of the page”. Maybe this is a browser thing. Can you please let me know what browser and version you are using?

    As for anchor links scrolling too far, I’d already accounted for this on the last update by making jQuery scroll less by the height of the navigation bar (which is what’s causing the problem). However, when linking from a different page I don’t think it has a chance to allow jQuery to deal with this so it will need some more thought.

    I’ve found a fix for the post date issue you pointed out which I’ll include in the next update.

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    I’ve just posted an update to address the post date issue on archive pages you raised.

    I’ve also changed the way that the #panelX-title IDs are injected into the page which hopefully should help to fix the “scrolling too far” issue.

    Still can’t replicate the “anchor links jumping to the top of the page” issue.

    Can you please let me know what browser and version you are using to see this?

    Thanks,

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Hi Oliver,

    the post date issue is solved, thank you very much.

    I actually added two front page sections (only in the English version of the site) and added two corresponding links “Test 1 and “Test 2” in the main menu below “Welcome”.

    The jumping to top does not longer happen, black magic?

    But at least on my Mac (macOS Sierra, Safari 11.1), it scrolls still beyond the page title. As I told you, I’m not a web developper, but I’ve seen others solving that via CSS with some negative padding…

    Edit: Same problem on same Mac with Firefox 60.0…

    I’ll leave these 2 test menu links in place for the moment to allow you testing this. The URL is https://theremin.academy

    Thank you for your patience!

    Thierry

    • This reply was modified 6 years, 4 months ago by Thierry.
    Thread Starter Thierry

    (@theremingenieur)

    Experimenting a little, I found that

    .panel-content {
        padding-top: 5.7em;
    }

    might be a valid workaround. Could this be injected via jQuery, too?

    • This reply was modified 6 years, 4 months ago by Thierry.
    Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    I think we’ve finally got the bottom of this. I’d completely missed the fact that you’d used the page sidebar option. This uses jQuery to move elements about to make it work (without modifying the theme or requiring a child theme).

    Sooooo anyway, you were right in that you needed padding but it was the reason *why* you needed padding that I was missing.

    Anyway, the latest update should have this sorted out for you.

    Please confirm.

    Kind regards,

    Oliver

Viewing 15 replies - 1 through 15 (of 40 total)
  • The topic ‘Cudos and feature requests’ is closed to new replies.