Current month not being selected on default

  • Resolved dccharron

    (@dccharron)


    9 years ago

    On upgrade to version 1.3.6 I found that when displaying the full calendar without specifying a “month” and a “yr” as parameters on the URL, the current month (in this case October) is not being selected in the pull down list of months and the current year (in this case 2015) is not being selected in the pull down list of years. Instead, the pull down list came up with a month of January and a year of 1985.

    I traced the problem down to changes made to the functions calendar_month_comparison and the calendar_year_comparison. Both have a line of code as follows:

    if (isset($get_year) && isset($get_month))

    I replaced this code in both functions with:

    if (($get_year!='') && ($get_month!=''))

    and it seemed to fix the problem.

    I think the ISSET function isn’t working the way you expected it to when using the string variables “$get_year” and “$get_month”. No doubt there is a more elegant solution but my PHP skills are rudimentary.

    https://www.ads-software.com/plugins/calendar/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Kieran O’Shea

    (@kieranoshea)

    Many thanks for letting me know about this, yes there is an issue here. I’ll try and push a fix out for it shortly.

    gnorf

    (@gnorf)

    Hi

    I have used the above fix (thanks dccharron) and it works but the year select still lists, for me back to 1997, which causes need for scrolling if picking a successive year, i.e. 2016).

    I suppose it should be possible to focus or change year select so that it doesn’t show years that far back, at least not without need for scrolling?

    Thanks ??

    pfuer

    (@pfuer)

    Hi dccharron
    I just did the fix you mentioned and it worked in my case!
    Thanks very much.

    BatRTiago

    (@batrtiago)

    Hi Kieran O’Shea,

    When is this problem solved?

    Thanks.
    GN

    Plugin Author Kieran O’Shea

    (@kieranoshea)

    Fix coming out for this shortly

    Plugin Author Kieran O’Shea

    (@kieranoshea)

    Fix was released last night, you should now find this is fixed

    Thread Starter dccharron

    (@dccharron)

    Your new release 1.3.7 has fixed the default month/year problem in the full calendar display. Thank you.

    No new issues detected.

    I must confess I always tweak your code a little to suit my preferences. I have a short “wish list” if you are amenable. Let me know. I realise you do this for free which is much appreciated so no pressure. I’m happy to keep tweaking.

    Plugin Author Kieran O’Shea

    (@kieranoshea)

    By all means create a new topic with your wish list, I’ll see what can be done in a future release

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Current month not being selected on default’ is closed to new replies.