Custom name label not working

Hi @mevilsizor,

thank you for reporting this. I will look into this! Your report is very clear, thank you for this!
I’ll post updates here if I have found anything.

Kind regards,

Jeroen Peters

Hi @mevilsizor,

I cannot seem to replicate this on my own site. Can you tell me which WordPress version you are using, if it’s WPMultiSite or not, and which PHP version?

Kind regards,

Jeroen Peters

I am using WP multisite, PHP 7.2.12. I have tried this on WP 5.0.2 and the version prior. My post above was when I was testing on my lab server. I have now performed the update on our production server, and if I make sure to clear the cache, then the custom label does take effect for the “There are currently 3 names in this directory” sentence, but it does not take effect for the following places on the list page
– Submit a name
– Submit a name

And it does not take effect on the submit a name form.

Perhaps it has not been fully implemented yet?
Seems like a singular and plural term may be needed?

Mark

Here are updated pictures (perhaps I had caching issues in my previous testing).

https://www.lindahall.org/wp-content/uploads/sites/5/2019/01/NameDirectory2-list.png

https://www.lindahall.org/wp-content/uploads/sites/5/2019/01/NameDirectory2-form.png

Hi @mevilsizor,

Thanks for clearing that up. You are right, the implementation needs more work. I Will work on this in the coming days.

Kind regards,

Jeroen Peters

Hi @mevilsizor,

I did some preparations, I think this weekend a new version with better support will be released.

Kind regards,

Jeroen Peters

I just installed the new version and it works great!

Per our conversation a long time ago I had been substituting translation files into the translation subfolder after each update in order to have the same effect. With this new feature I can update normally and describe the list appropriate for our use.

Thank you very much!

Mark

Hi @mevilsizor / Mark,

I am glad that it works for you and that you are happy this feature works (now all the way in the plugin).

Thanks for using the plugin! I hope you would consider writing a reciew or making a small donation.

Kind regards,

Jeroen Peters