custom post type and generatepress block

Hi @outdoorsdev1,

I just tagged version 1.13 with support for GenerateBlocks. Has been on my to-do list anyway.

Is it possible that the image in the /card/ post is in a reusable block?

In the Style Guide the link to the full is missing for the GenerateBlocks image.

Thanks for pushing the update, that has fixed the issue with the single post and you were right that I hadn’t linked that image to its source. I appreciate the prompt reply and the plugin itself ??

Yes, this image is in a reusable block which has a dynamic link to the image and also the source in a GB image block. They’re pulled from ACF data if that’s of any use.

The problem is that the has_block function from WordPress just checks the main post, not an embedded reusable block (which is a post, too). There is a workaround: https://github.com/goaround/gallery-block-lightbox/issues/11 But presently this comes with a performance decrease. I still hope WordPress itself will fix it.

You can add the following snippet to functions.php:
add_filter( 'baguettebox_enqueue_assets', '__return_true' ); and the script & style will load everywhere. This is a easy fix, if you use the Gallery on every page anyway.

This is again really helpful, thanks.

As i’d probably be using this on most pages, is it possible to just call it on all blog or specific post types (i use a custom post type) instead of running a check?

Also found this

https://github.com/WordPress/gutenberg/issues/18272

this checks to see if a block is reusable, if I add this using code snippets would it be less resource intensive than your workaround?

function has_reusable_block( $block_name, $id = false ){
    $id = (!$id) ? get_the_ID() : $id;
    if( $id ){
        if ( has_block( 'block', $id ) ){
            // Check reusable blocks
            $content = get_post_field( 'post_content', $id );
            $blocks = parse_blocks( $content );

            if ( ! is_array( $blocks ) || empty( $blocks ) ) {
                return false;
            }

            foreach ( $blocks as $block ) {
                if ( $block['blockName'] === 'core/block' && ! empty( $block['attrs']['ref'] ) ) {
                    if( has_block( $block_name, $block['attrs']['ref'] ) ){
                       return true;
                    }
                }
            }
        }
    }

    return false;
}

In testing, now on that page the assets to load to bring up the lightbox but not the image itself?

https://pastebin.com/YGL67pQS

@outdoorsdev1 this is the workaround I mean. But it runs parse_blocks, which is a heavy function, on every check for every reusable post for every block.

@outdoorsdev1 try

add_filter( 'baguettebox_enqueue_assets', function ($load) { return $load ?: is_singular('card'); } );

If the name of the post type is card

• This reply was modified 2 years, 2 months ago by Johannes Kinast.

I very slightly changed that to be

add_filter( 'baguettebox_enqueue_assets', function ($load) { return $load ?: is_singular(array('card', 'post' )); } );

so it works for posts and card type posts.

Still though, on card pages only the lightbox comes up, but not the image?

Make sure to clear the Cache or restart PHP

That doesn’t seem to have changed anything. The post does pull from an element within generatepress if that makes a difference, maybe the element (a content template) needs to be referenced too?

When inspecting on this page https://pastebin.com/gWT6ZeCE

it looks like there is a javascript error in the console when clicking the image

Uncaught TypeError: Node.removeChild: Argument 1 is not an object.

There are a couple of posts on the homepage you can check out that seem to be fine.

@outdoorsdev1 it seems to be an error inside baguettBox.js: https://feimosi.github.io/baguetteBox.js/

On my test site it works fine with GeneratePress. I can’t help you here anymore. Sorry.