customfield_display not working

Hi, have you tried it without specifying a custom template, just to see if the customfield is displayed in that case?

I tried that, and indeed, the custom field is being displayed then.

I don’t quite understand why it is no longer showing now, as I only moved one line higher in the code, and added a few tags here and there for styling.

Here is what I have:

foreach ($this->catlist->get_categories_posts() as $single){
  //Start a List Item for each post:
  $lcp_display_output .= '<li class="mini-post-holder clearfix">';

   //Post Thumbnail
  $lcp_display_output .= $this->get_thumbnail($single);

  //Show the title and link to the post:
  $lcp_display_output .= "<h4>".$this->get_post_title($single)."</h4>";

  //Show comments:
  $lcp_display_output .= $this->get_comments($single);

  //Show date:
  $lcp_display_output .= ' ' . $this->get_date($single);

  //Show author
  $lcp_display_output .= $this->get_author($single);

  //Custom fields:
  $lcp_display_output .= $this->get_custom_fields($this->params['customfield_display'], $single->ID);

  /**
   * Post content - Example of how to use tag and class parameters:
   * This will produce:<p class="lcp_content">The content</p>
   */
  $lcp_display_output .= $this->get_content($single, 'p', 'lcp_content');

  /**
   * Post content - Example of how to use tag and class parameters:
   * This will produce:<div class="lcp_excerpt">The content</div>
   */
  $lcp_display_output .= $this->get_excerpt($single, 'div', 'lcp_excerpt');

  //Close li tag
  $lcp_display_output .= '</li>';
}

Any idea what I did wrong?

Hi, I don’t think you did anything wrong.

I’ve found a bug in the LCP version 0.51 lcp-catlistdisplayer.php code.
In an older version which I have the get_custom_fields function used to have several parameters, the first of which was the setting of customfield_display. For some reason, the author has removed that and the function now only has the post_id as a parameter passed to it.

For a quick fix if you change this line in your template:
$lcp_display_output .= $this->get_custom_fields($this->params[‘customfield_display’], $single->ID);

to
$lcp_display_output .= $this->get_custom_fields($single->ID);

you may find it works. Let us know, because there must be hundreds, if not thousands, of templates that are now broken.

Just a thought, it may be sensible to leave both your old line in as well as put in the new line, just in case the author ever goes back to the old way (or you go back to an older version of the plugin).

***CORRECTION***

sorry, the author has also changed the way the post id is send to get_custom_fields so your new line should be:
$lcp_display_output .= $this->get_custom_fields($single);

ie without the ->ID (he now picks up the info about whether customfields are to be displayed from the object, so you don’t need to send the parameters separately).