Database prefix

  • Resolved dpik

    (@dpik)


    8 years, 10 months ago

    Hi,

    Found a little bug in this plugin: wordpress database prefix is hardcoded in some places in src/lib/classes/reporting/reports/WC22/vies_report.php

    Here is a patch to help you locate the error:

    --- src/lib/classes/reporting/reports/WC22/vies_report.php	2015-07-22 12:20:16.000000000 +0200
+++ vies_report.php	2016-02-01 11:00:43.760137963 +0100
@@ -62,11 +62,11 @@
 					(PROD_META.meta_key = '". Definitions::FIELD_VIES_PRODUCT_IS_SERVICE . "')
 				-- Get product data for variable products
 				LEFT JOIN
-				wp_woocommerce_order_itemmeta AS OIM3 ON
+				{$px}woocommerce_order_itemmeta AS OIM3 ON
 					(OIM3.order_item_id = OI.order_item_id) AND
 					(OIM3.meta_key = '_variation_id')
 				LEFT JOIN
-				wp_postmeta AS VARIATION_META ON
+				{$px}postmeta AS VARIATION_META ON
 					(VARIATION_META.post_id = OIM3.meta_value) AND
 					(VARIATION_META.meta_key = '". Definitions::FIELD_VIES_PRODUCT_IS_SERVICE . "')
 				-- Fetch orders meta
@@ -180,12 +180,12 @@
 					(PROD_META.meta_key = '". Definitions::FIELD_VIES_PRODUCT_IS_SERVICE . "')
 				-- Get product data for variable products
 				LEFT JOIN
-				wp_woocommerce_order_itemmeta AS RIM3 ON
+				{$px}woocommerce_order_itemmeta AS RIM3 ON
 					(RIM3.order_item_id = RI.order_item_id) AND
 					(RIM3.meta_key = '_variation_id')
 				LEFT JOIN
 				-- Determine if the variation is to be considered a service for VIES purposes
-				wp_postmeta AS VARIATION_META ON
+				{$px}postmeta AS VARIATION_META ON
 					(VARIATION_META.post_id = RIM3.meta_value) AND
 					(VARIATION_META.meta_key = '". Definitions::FIELD_VIES_PRODUCT_IS_SERVICE . "')
 				JOIN

    Regards, Damien

    https://www.ads-software.com/plugins/woocommerce-eu-vat-assistant/

Viewing 1 replies (of 1 total)
  • Plugin Author Diego

    (@daigo75)

    Hi Damien,
    Thanks for the report. We also spotted that issue, and we fixed it in an upcoming release. It’s interesting that nobody spotted it before, probably because few people, if any, run the VIES report (we originally developed it for our own internal use).

Viewing 1 replies (of 1 total)
  • The topic ‘Database prefix’ is closed to new replies.