db migration run to often

  • Resolved Maciej Ma?kowiak

    (@maciejmackowiak)


    4 years, 7 months ago

    Hello,

    While updating plugin we’ve run into an issue with DB migration – it triggers on every pageview. Wouldn’t it be better to run it only when updating plugin or at least run it only for admin_init hook instead of init hook?

    For high traffic website it is a problem – please take a look at this screenshot:
    BLC-db-migration.png

    Thanks in advance
    Maciej

Viewing 7 replies - 1 through 7 (of 7 total)

  • Thankfully, once the first of each of these queries that modified one column at a time completed, the rest realized there’s nothing for them to do and immediately exited, but they still took up mysql connection slots and hung the db, so this should definitely be fixed.

    Hello @maciejmackowiak

    I trust you are doing well!

    I’ve forwarded this issue to our developers so they could provide some feedback. Once we have an update we will follow back in here.

    Kind regards,
    Nastia

    Hello @maciejmackowiak
    I had a look at this and you’re right there are a lot of unnecessary query running on upgrade and it’s running on the front pages as well.

    I’ve added it for development and this will possibly be fixed on the upcoming release.
    Thanks for taking your time to report the issue and help us make the plugin better.

    Regards,
    Biplav

    It happened again (judging by the comments at least – we haven’t updated yet for this reason) https://www.ads-software.com/support/topic/update-1-11-13-broke-the-site/.

    • This reply was modified 4 years, 6 months ago by archon810.

    Hello @archon810
    Yeah it’s true we tried to run the DB queries again because of the issue that was reported here just to optimize them and make them a little better, this is just a foundation for the next future updates where are trying to stop running these expensive queries.

    Thank you for your patience.
    Kind regards,
    Biplav.

    The other issue was closed, and I don’t really understand what you’re doing now to correct this one.

    Please address the fact that you run db migration when any visitor comes to the page rather than only doing it for the first access to wp-admin. Your approach makes no sense.

    Db migrations are fine and are necessary sometimes, but performing them in the way you’re doing now is unacceptable.

    Can we expect a fix for this procedure in a future update?

    Plugin Support Amin – WPMU DEV Support

    (@wpmudev-support2)

    Hello @archon810 ,

    Like @bplv mentioned, our team is working on fixing that in the upcoming versions of the plugin.
    We appreciate your patience.

    kind regards,
    Kasia

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘db migration run to often’ is closed to new replies.