Dead Plugin – Please Update Description Noting Plugin is No Longer Being Updated

Reference this topic for an abbreviated description of the exact issue.

Error logs fill up with the following, and running WP-CLI without the --skip-plugins flag will cause any and all WP-CLI commands to fail:
PHP Fatal error: Call to a member function get_options() on a non-object in plugins/simplemap/classes/maps.php on line 116

The exact issue can be found in simplemap/classes/maps.php, a file which states This handles ONLY single location maps and also mentions Handles all our map making duties (well it will be taking over shortly anyway). Whether or not this file in fact handles “single location maps”, “all map making duties”, or both single and all maps is anyone’s guess.

But that doesn’t seem to matter anymore considering it’s been over 7 months since the developer pushed out a broken update, never once thinking to check if the last update was taking down sites because of errant code.

The method set_map_atts within this SM_Map_Factory parent class attempts to pull default map settings via $defaults = $simple_map->get_options(); but the $simple_map global (gross) object doesn’t actually contain that default data. Instead, the file simplemap/classes/simplemap.php actually contains the get_options method with default data, but isn’t assigned to that $simple_map global object.

Of the various possible fixes, the quickest might be to manually change line 116 in simplemap/classes/maps.php from $defaults = $simple_map->get_options(); to $defaults = get_option( 'SimpleMap_options' );. However, this call to $simple_map->get_options(); is strewn throughout the codebase so many times that it isn’t even worth trying to fix.

Not to mention this plugin makes liberal use of JavaScript eval(), a function that MDN itself clearly states Do not ever use eval!.

This plugin should be removed from the repository and a big red warning should be affixed to the top of the page: “DO NOT USE THIS DEAD PLUGIN!”

• This topic was modified 6 years, 1 month ago by Lee Peterson.
• This topic was modified 6 years, 1 month ago by Lee Peterson.

The page I need help with: [log in to see the link]