• Resolved Surbma

    (@surbma)


    Hi,

    I just upgraded to 3.0 and realized, that the single view Default Page Template is not compatible with Genesis framework’s themes. I couldn’t figure out, how you include the content, but I guess it’s related to the method, you include it.

    Please make this plugin compatible with Genesis, but I guess I can say, to make it compatible with every WordPress themes.

    I don’t know, why you have chosen such a difficult way to include the content for single view. There is the the_content filter, which is the most recommended way to add extra content.

    There are also issues with the event title, which is also not a standard implementation. Also it is not displayed with h1, instead you display it with h2 tag. I don’t know the reason, but it is not the best tag for the page’s main title. And I don’t understand why don’t you let the WordPress theme to display the title, if I choose the Default Page Template option. It should do, what it says, render the content with the default template. This is not a default template, this is a custom template.

    Please make a default template, which works as expected and which was working before 3.0 version. Thank you!

    https://www.ads-software.com/extend/plugins/the-events-calendar/

Viewing 15 replies - 1 through 15 (of 24 total)
  • Hi Surbma,

    Sorry to hear about the issues here. I’m running Genesis 1.9.2 and the Default Page Template works fine for me. It’s not full width, but those are modifications you would need to make on your own.

    What version of Genesis are you running?

    Thread Starter Surbma

    (@surbma)

    It is strange, that it is working for you. I have tested it on other Genesis sites as well and neither is working. I’m using the latest version of Genesis and WordPress also. I even deactivated all plugins. If I switch to Twenty Twelve, it works fine. So it is related to Genesis somehow.

    I give you the links of the sites. I’ve made a staging area, where I switched to Genesis Sample child theme just to be sure, that it is not a customized Genesis child theme.

    Here is the live site with Default Events Template:
    Events page: https://ungarischertourismus.at/events/
    Event page: https://ungarischertourismus.at/event/the-island-of-freedom-is-born/

    Here is the staging site with the Default Page Template:
    Events page: https://ungarischertourismus-at.premiumwp.staging.wpengine.com/events/
    Event page: https://ungarischertourismus-at.premiumwp.staging.wpengine.com/event/the-island-of-freedom-is-born/

    As you can see, the template breaks the layout. The events listing page is not working at all.

    And as I have written, I don’t understand why don’t you use all the standard functions, when the Default Page Template is chosen, like the title of the post. I think the Default Page Template should not use any custom display, it should use only WP standard codes.

    We are experiencing the same issue on some Woothemes Canvas theme, some sites are working where others is not – reverting to version 2.0.11 resolves the issue.

    @athalas: As per the Forum Welcome, please post your own topic. You are using a completely different theme.

    Thread Starter Surbma

    (@surbma)

    My topic contains Genesis, but I think this issue is not related only to Genesis, but every theme framework, that uses hooks or a very customized display.

    So I agree with @athalas, that this ticket can be related to other frameworks and themes as well.

    My opinion is that we need a REALLY Default Page Template, that uses only WP’s standard codes. The content should be extended with the the_content filter.

    Can you please link to your Genesis site, where you use the latest versions of Genesis and the plugin and it uses Default Page Template without any issue?

    I think this issue is not related only to Genesis, but every theme framework, that uses hooks or a very customized display.

    Nevertheless, the forum rules around here clearly state:

    Unless you are using the same version of WordPress on the same physical server hosted by the same hosts with the same plugins, theme & configurations as the original poster, do not post in someone else’s thread. Start your own topic.

    https://codex.www.ads-software.com/Forum_Welcome#Where_To_Post

    Hi all,

    Just a quick update that may help – we identified a unclosed div in our code which we will be fixing in a release shortly. In the interim please try adding a closing div to the After HTML option in Events > Settings > Display to see if that helps.

    – Jonah

    Thread Starter Surbma

    (@surbma)

    Hi Jonah,

    actually it solved the single event page issue, so at least the event is showing correctly.

    But the /events/ page still doesn’t work. ??

    And this is not a final solution for the single event page also, because the title is still with h2 tag, so the main issue is still there. The main issue with this template is, that it should use the theme’s default page template instead of any custom template.

    This is still a custom template, not a Default Page Template, as its name says. I don’t understand, why do you want to use it like this?

    @esmi – Why do you remove comments, that related to the topic??? Are you playing some control game? If you are not right, you just delete a comment??? I don’t think this is the right way. You’ve deleted my comment, which was about this thread. You shouldn’t do this!

    Thread Starter Surbma

    (@surbma)

    I’ve upgraded to 3.0.1 and I’m glad, that the event page is (somehow) fixed, even if it is still not the perfect solution, but the events page is still not working. So please investigate more to find out, why is it in conflict with Genesis.

    Thank you!

    Same problem. Events main page not working with Canvas. (single event working)

    BTW, people arguing about the forum’s rules should start thinking out of the box a little bit. Who cares if it’s Genesis or Canvas, the issue IS the same! You do find this thread whether you are with one theme or the other, Who cares…

    All we need is a fix.

    Hi Surbma,

    What is the issue that you are having with the title? Have you looked at this FAQ: https://tri.be/faqs/the-calendar-page-title-shows-title-of-an-event/

    @emue – All theme’s are different and require different fixes. We do have a fix for Canvas but it has not been publicly implemented yet. You can however apply the fix by pasting this code into your theme’s functions.php file: https://gist.github.com/jazbek/5959855

    Regards,
    – Jonah

    Thread Starter Surbma

    (@surbma)

    There is no issue with the title. My problem is, that the default page template should use the DEFAULT PAGE TEMPLATE, not a custom page template. You are using h2 tag for the title, which doesn’t make any sense, it should be h1.

    I just don’t understand why do you customize the DEFAULT template? It should be exactly, what it says: default!

    It is really good to have custom templates as well, I have no problems with custom templates. But it says default, so I expect to see the default template, what my theme (now Genesis) uses and how it shows.

    It is not a big issue, but annoying. Even if you don’t want to change it, I can live with it.

    BUT there is an issue with the events page, that should be fixed. I’m waiting for the fix for this issue.

    Thanks Jonahcoyote, However, the code you gave me is giving me the following error : Parse error: syntax error, unexpected ‘<—/functions.php on line 113

    I don’t mind opening another thread if necessary. If you get a fix, that would be great, in the mean time, I am not using the main Event template.

    @surbma – I don’t think we will be changing the h2 tag. You’ll need to figure out some other way to change this on your own. What is the issue with the events page?

    @emue – you must have pasted the code in wrong. Make sure you are not pasting after PHP has been closed. You need to follow proper PHP coding and since I cannot see your functions.php file, I have no idea how the code should be pasted in.

    Thread Starter Surbma

    (@surbma)

    Is there any reason, you don’t want to use the best SEO practices? Is there any reason for the h2 tag?

    I will be happy to use my theme’s default page template if you make a REAL default page template for the plugin. ??

    Did you see my links? I don’t know what is the issue with the events page, it just doesn’t work. So please click on my links above (which I gave 2 weeks ago) and you will see the problem.

Viewing 15 replies - 1 through 15 (of 24 total)
  • The topic ‘Default Page Template is broken with Genesis themes’ is closed to new replies.