default-template.php

  • Resolved RobMackay

    (@robmackay)


    8 years, 6 months ago

    could you guys add a check for the get_header() / get_footer() just because using a wrapper like Roots sage builds the theme a little different and the headers are already called in this instance.

    Adding:

    if(!$wp_did_header)

    above get_header() and get_footer(). Resolves headers being sent twice, etc etc or something like that ??

    That would be awesome ??

    Thanks!

    https://www.ads-software.com/plugins/the-events-calendar/

Viewing 1 replies (of 1 total)
  • Brook

    (@brook-tribe)

    Howdy Rob,

    Thanks for taking the time to reach out with your suggestion!

    We typically keep logic in those templates to a minimum that way they are easier to work with and customize for laymen. In the interest of being up front and transparent, I don’t think this is something we would be keen to add to our plugin for all users/themes.

    I’m sure you know this already, but you can override that file with your own copy inside of your theme folder. If you place the check inside of your overriden copy, the issue should go away. Have a look at the Themer’s Guide for more info. At least for now this would be how to make things compatible with Roots Sage.

    Does that all make sense?

    Cheers!
    – Brook

Viewing 1 replies (of 1 total)
  • The topic ‘default-template.php’ is closed to new replies.

Tags