deprecation notice and patch (WordPress 3.8)
-
Got some deprecation message from mutli-site backend:
( ! ) Notice: register_uninstall_hook was called <strong>incorrectly</strong>. Only a static class method or function can be used in an uninstall hook. Please see <a href="https://codex.www.ads-software.com/Debugging_in_WordPress">Debugging in WordPress</a> for more information. (This message was added in version 3.1.) in /var/www/wordpress/wp-includes/functions.php on line 3049 Call Stack # Time Memory Function Location 1 0.0001 238256 {main}( ) ../my-sites.php:0 2 0.0444 239560 require_once( '/var/www/wordpress/wp-admin/admin.php' ) ../my-sites.php:10 3 0.0445 240296 require_once( '/var/www/wordpress/wp-load.php' ) ../admin.php:30 4 0.0447 241264 require_once( '/var/www/wp-config.php' ) ../wp-load.php:34 5 0.0450 243712 require_once( '/var/www/wordpress/wp-settings.php' ) ../wp-config.php:73 6 0.0823 2675968 include_once( '/var/www/wordpress/wp-content/plugins/simple-ads-manager/simple-ads-manager.php' ) ../wp-settings.php:176 7 0.0827 2750824 SimpleAdsManagerAdmin->__construct( ) ../simple-ads-manager.php:39 8 0.1017 3201856 register_uninstall_hook( ) ../admin.class.php:31 9 0.1018 3202352 _doing_it_wrong( ) ../plugin.php:700 10 0.1018 3203648 trigger_error ( ) ../functions.php:3049
A admin notice not yet fixed:
( ! ) Notice: Undefined offset: 1 in /var/www/wordpress/wp-content/plugins/simple-ads-manager/admin.class.php on line 226 Call Stack # Time Memory Function Location 1 0.0001 238256 {main}( ) ../my-sites.php:0 2 0.0444 239560 require_once( '/var/www/wordpress/wp-admin/admin.php' ) ../my-sites.php:10 3 0.0445 240296 require_once( '/var/www/wordpress/wp-load.php' ) ../admin.php:30 4 0.0447 241264 require_once( '/var/www/wp-config.php' ) ../wp-load.php:34 5 0.0450 243712 require_once( '/var/www/wordpress/wp-settings.php' ) ../wp-config.php:73 6 0.0823 2675968 include_once( '/var/www/wordpress/wp-content/plugins/simple-ads-manager/simple-ads-manager.php' ) ../wp-settings.php:176 7 0.0827 2750824 SimpleAdsManagerAdmin->__construct( ) ../simple-ads-manager.php:39 8 0.1023 3214336 SimpleAdsManagerAdmin->getWpVersion( ) ../admin.class.php:57
And some patch for annoying front-end notices:
--- a/wp-content/plugins/simple-ads-manager/ad.class.php +++ b/wp-content/plugins/simple-ads-manager/ad.class.php @@ -161,7 +161,7 @@ if(!class_exists('SamAdPlace')) { } private function getSettings() { - $options = get_option(SAM_OPTIONS_NAME, ''); + $options = get_option(SAM_OPTIONS_NAME, ''); return $options; } @@ -225,7 +225,7 @@ if(!class_exists('SamAdPlace')) { $rId = rand(1111, 9999); if($settings['adCycle'] == 0) $cycle = 1000; else $cycle = $settings['adCycle']; - $el = (integer)$settings['errorlogFS']; + $el = isset($settings['errorlogFS']); global $wpdb; $pTable = $wpdb->prefix . "sam_places"; @@ -296,7 +296,7 @@ if(!class_exists('SamAdPlace')) { return $output; } - if(($settings['adShow'] == 'js') && !$this->force) { + if(isset($settings['adShow']) && ($settings['adShow'] == 'js') && !$this->force) { //$data = "{id: 0, pid: {$place['id']}, codes: $codes}"; return "<div id='c{$rId}_0_{$place['id']}' class='sam-container sam-place' data-sam='{$data}'></div>"; } diff --git a/wp-content/plugins/simple-ads-manager/sam.class.php b/wp-content/plugins/simple-ads-manager/sam.class.php index e281b85..b03e309 100644 --- a/wp-content/plugins/simple-ads-manager/sam.class.php +++ b/wp-content/plugins/simple-ads-manager/sam.class.php @@ -519,25 +519,25 @@ if ( !class_exists( 'SimpleAdsManager' ) ) { } public function doAdShortcode($atts) { - shortcode_atts( array( 'id' => '', 'name' => '', 'codes' => ''), $atts ); + $atts = shortcode_atts( array( 'id' => '', 'name' => '', 'codes' => ''), $atts ); $ad = new SamAd(array('id' => $atts['id'], 'name' => $atts['name']), ($atts['codes'] == 'true'), $this->crawler); return $ad->ad; } public function doShortcode( $atts ) { - shortcode_atts( array( 'id' => '', 'name' => '', 'codes' => ''), $atts ); + $atts = shortcode_atts( array( 'id' => '', 'name' => '', 'codes' => ''), $atts ); $ad = new SamAdPlace(array('id' => $atts['id'], 'name' => $atts['name']), ($atts['codes'] == 'true'), $this->crawler); return $ad->ad; } public function doZoneShortcode($atts) { - shortcode_atts( array( 'id' => '', 'name' => '', 'codes' => ''), $atts ); + $atts = shortcode_atts( array( 'id' => '', 'name' => '', 'codes' => ''), $atts ); $ad = new SamAdPlaceZone(array('id' => $atts['id'], 'name' => $atts['name']), ($atts['codes'] == 'true'), $this->crawler); return $ad->ad; } public function doBlockShortcode($atts) { - shortcode_atts( array( 'id' => '', 'name' => ''), $atts ); + $atts = shortcode_atts( array( 'id' => '', 'name' => ''), $atts ); $block = new SamAdBlock(array('id' => $atts['id'], 'name' => $atts['name']), $this->crawler); return $block->ad; }
Misused/ unused
shortcode_atts
, some offset-not-defined issues, nothing major.If you have a github repository of it I may provide a pull-request.
Viewing 5 replies - 1 through 5 (of 5 total)
Viewing 5 replies - 1 through 5 (of 5 total)
- The topic ‘deprecation notice and patch (WordPress 3.8)’ is closed to new replies.