Developer Friendly

  • wpexplorer

    (@wpexplorer)


    1 week ago

    I’m working on integration of this plugin with my Total theme.

    I just wanted to say, it’s one of the best documented LMS (or any free) plugin. Lots of helpful core functions, action hooks and filters. Also, the default styling is nice and minimal making it easy to override.

    So far, everything seems really good.

    I do have some small design-related recommendations:

    • Update the CSS to use modern custom CSS properties (variables) for colors so borders, accents, etc can be easily modified globally.
    • An old version of FontAwesome is caked into the admin & frontend CSS. This creates extra bloat/conflicts if other plugins are also loading FontAwesome. Moving the CSS out to it’s own file and loading only when needed is better, but switching to SVG icons would be best.
    • CSS can be updated to remove unnecessary vendor prefixes.
    • The llms-notification-icon is using an image. This makes it impossible to modify if we want the colors to be dynamic.
    • Metabox UI doesn’t match core WP styles.

    I may have some other recommendations later as I’ve only been working on the integration for an hour or so. I just wanted to leave a rating before I forget as the plugin deserves it. If anything just for the quality of the documentation.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Chris Badgett

    (@chrisbadgett)

    Thank you for working on integrating Total theme with LifterLMS.

    And thank you for the feedback.

    Please keep us posted on the integration.

    Plugin Author Brian Hogg

    (@brianhogg)

    Thanks @wpexplorer for the review and for the notes! We’ll review your feedback and see if there are changes we can make on our end to make the job of a theme developer easier.

    You may have already discovered this, but for the notification image vs. icon, you could add some CSS to hide the image itself and add an icon of your choosing. Alternatively and probably better from a theme point of view, you should be able to override templates like templates/notifications/basic.php and remove the image altogether with these instructions:

    https://lifterlms.com/docs/lifterlms-templates/

    In your case it would be in your theme itself which others could override further by creating a child theme of Total.

    Feel free to reach out by creating a new support thread if you run into any other issues or blockers, and we can do our best to point you in the right direction.

Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this review.