• Resolved Muhammad Qureshi

    (@thequreshi)


    Hi there,

    First of, Dokan is great. The free is version is great and the paid version is amazing. However, to make it “awesome” I have to make some changes to it.

    Whenever I search in the support forums (WordPress forum and Dokan website) for a fix, I see that the support representatives including the plugin authors suggest to “comment out x line in /includes/xyz.php file”.

    As a developer, it is pain in the eyes to read it. I mean, to the best of my knowledge, directly editing plugin files is not at all recommended as the changes will be overwritten as soon as the plugin is updated.

    Am I missing something? Please guide!

Viewing 4 replies - 1 through 4 (of 4 total)
  • Hello @thequreshi ,

    Thanks for your thoughtful query.

    You are right on the comment that the changes will be gone with the update. Our first priority on a modification is that you use a child theme and if there is any hook available then use that to make the modification. But sometimes due to the customer request we have to suggest them to modify a core plugin file. We always notify them the changes will be gone with the update so try to keep a backup of the modification.

    We are trying to make our plugin more developer-friendly so hopefully in future you can work on the code without modifying the core files.

    Regards,
    Rashed

    Thread Starter Muhammad Qureshi

    (@thequreshi)

    Thanks for the response, Rashed.

    I see you mentioned that “sometimes due to the customer request we have to suggest them to modify a core plugin file”

    Is it the right way to provide support? Certainly not. The right way is to tell them the right hook that they can use in the child themes for the customization.

    The job of the support team should be to guide the customers to the right hook rather than suggesting direct edits!

    Best,
    Qureshi

    Hello @thequreshi ,

    I get your point but I have already explained why we do that and also we made sure to notify the user about the consequences. Please check this part of my reply –

    if there is any hook available then use that to make the modification. But sometimes due to the customer request we have to suggest them to modify a core plugin file. We always notify them the changes will be gone with the update so try to keep a backup of the modification.

    Providing the right hook and file locations are our first task whenever we are asked to providing customization guideline. I think you misunderstood my last reply. However, thanks for your input and we will try our best to implement your suggestion in our practice.

    Thank you.

    Thread Starter Muhammad Qureshi

    (@thequreshi)

    I understood your reply brother ??

    Anyway, I have made my point. Which is that the support team should NOT suggest direct editing of the files under ANY circumstances whatsoever.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Directly editing plugin files?’ is closed to new replies.