Disabled block editor on updating to 6.x (when Redis object cache is used)

Looking in the github repo, I think I found the commit that has caused all this trouble for us. Before this commit the editor toggle was saved in a static property, but this commit changed that to using the cache for test purposes. Helas it broke compatibility with Redis in doing so.

Commits on Sep 6, 2022
Cache the block editor toggle via cache object 
Using the cache object rather than <code>static::</code> values allows automated tests to expire the cache.
@borkweb

The link to this commit is:
https://github.com/the-events-calendar/the-events-calendar/commit/4fd81db59018fa05e02fe3a3e536a13f77e6c1aa

It seems to be merged in TEC version 6.0.1, so that explains why it broke since version 6.

Also I found that when I manually store the string value “1” in the toggle key in Redis, that the functionality seems to work, but of course that would hard code the outcome instead of letting the settings do that.

Please undo this commit or change the solution so it will work with Redis too. More details on what happens using redis, in the other thread.

Hi @hanswitteprins,

Thanks for reaching and bringing this to our attention.

Our development team has started tracking this in a bug report in our internal system, and a fix for this will hopefully be added to a future update of the plugin.

Many thanks for digging into this and sharing the details.

Kind regards,
Masood

(Ref: TEC-4613)

@masoodak Thanks for informing me. Hope it will get fixed soon now.

Kind regards,
Hans

It seems that the stuff that breaks things for me are often done for some technical dev related reason rather than for functionality that is important for me as a user. I’m not sure that’s a good thing.

F.i. I still have to remove manually the statements that hijack the post in /src/Tribe/Views/V2/Template/Page.php line 241 and 242 so my themes header can show event titles. It’s been reported by me, but for some use case (so it said?) it is still in. Using blame I only traced it back to a commit that wanted to split page and event template, but that’s not a concern for me. For me it only means my theme isn’t able to get the event title when it builds the header and I need to fix that myself.

or how switching to blocks means having metadata like tickets related to an event in the html so when I use the most populair (yoast) duplication plugin that has always worked for me on events, I now have to remove the tickets related tags in the code editor to clean up the duplicated event.

Perhaps the gutenberg site editor and newer versions of plugins will fix that sort of problems eventually, but until it does changes are not save enough and seems to need technical skils to implement in the sites. It should ideally be more dummy proof.

Hi @hanswitteprins, thanks for sharing more information and for being active on our threads regarding this issue. Also, regarding bug ticket #TEC-4613, it is now Pending QA.

Rest assured that we’re sharing the information you shared here with our team.

Hang in there,
Abz

—
Bug Ticket Reference: TEC-4613

Hi there,

We’re back with good news!

Our developers have just released the Events Calendar version 6.0.7, which addresses the issue crashing the Blocks Editor whem the Redis Object cache is activated.

Please update your Events Calendar plugin to include those improvements over your website.

Best regards,

Hi @hanswitteprins

This thread has been inactive for a while, so we’ll go ahead and mark it Resolved. Please open a new thread if any other questions arise, and we’d be happy to help.