Do you have a repo where we can submit PRs?
-
I love your plugin.
Do you have a GitHub repo where we can submit pull requests?
I wanted to support TypeScript syntax highlighting, but for that, CodeMirror expects the object style of mode specification, i.e. instead of
mode: 'typescript'
it has to be something likemode: { name: 'javascript', typescript: true }
. Alternatively, to get TypeScript, CodeMirror allows using a MIME type as the mode specification, e.g.mode: 'text/typescript'
. Since your plugin uses themode
prop both as the CodeMirror specifier and also as the name of the syntax file to be downloaded, it means that it’s not possible out-of-the-box to support such styles.I was able to modify your plugin to make it do what I wanted. I hate modifying plugins directly, though because the next time you upgrade it, I’ll have to either not upgrade or re-implement my changes.
I would love to submit a pull request that will support this scenario without introducing a breaking change.
Thanks!
- The topic ‘Do you have a repo where we can submit PRs?’ is closed to new replies.