Doesnt work on Firefox with adBlock disabled

  • https://www.film-tv-video.de/

    If you disable adblock on the site, the site still shows the adblock banner. I found the problem. Chrome doesnt run the test for the height of the footer_ad div until all images have been loaded, but firefox runs it before images has been loaded, resulting in height==0

    if ( jQuery( ".footer_ad" ).height() == 0 ) {

    Maybe another check (display?) would be better, or even put the IF inside a timeout function.

    PS: This can be the reason of other browsers failing to detect this.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Pat O’Brien

    (@obrienlabs)

    This is a great suggestion and could help with other detection issues like you mentioned. I’ll run some tests with it!

    The timeout isn’t a bad suggestion either. I see on your site you have it set to 5 seconds. I could implement that as well as a user option instead of hard-coding it. That way if someone feels 5 seconds is too long, they can change it and/or disable it.

    Plugin Author Pat O’Brien

    (@obrienlabs)

    Updated to 1.3 which adds the ability to enable/disable the timeout function and set the delay time. Thanks again

    igor871

    (@igor871)

    Why use timeout? Can’t you just run the test inside $(window).load(function() {}); ?

    Plugin Author Pat O’Brien

    (@obrienlabs)

    I’m using jQuery(document).ready() right now, but as we’re seeing it’s running the height check when the DOM is loaded, not the images. Perhaps you’re right with the $( window ).load(function() since that runs after images are done.

    I’ll do some testing. Thanks

    Plugin Author Pat O’Brien

    (@obrienlabs)

    @igor871 The $( window ).load(function() seems to be working pretty well (as it should). I’m going to remove the timer function since I think it’s not needed. Thanks for the feedback. This updated detection method will be in 1.4.

    igor871

    (@igor871)

    Great. I think that should be more reliable then timer, that’s why I suggested it.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Doesnt work on Firefox with adBlock disabled’ is closed to new replies.

Tags