Doesn’t work with Bedrock

  • Resolved Nicscott01

    (@nicscott01)


    9 months ago

    This plugin doesn’t work with Bedrock installs because the admin is placed inside the “wp” folder. The function get_site_url() returns the domain with the folder, like this:

    https://www.example.com/wp

    This makes the logic fail towards the end of the plugin file.

    I think the safe fix is to use get_home_url() instead of get_site_url(). Or perhaps you look for the defined constant WP_HOME which is what Bedrock uses to define the website home. If that’s defined, then use that in the logic to check if we have the has URL.

    What do you think? Can you change this?

    • This topic was modified 9 months ago by Nicscott01.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Gulshan Kumar

    (@thegulshankumar)

    Please try the version 1.1.5 and let me know how it goes. Thank you.

    Thread Starter Nicscott01

    (@nicscott01)

    Thanks for making that change. It didn’t work, and I know why. It’s because I never changed the function get_site_url() in line 78. That function actually should stay get_site_url() because wp-comments-post.php is located in the folder wp/ when using Bedrock. So, in that case the URL should stay /wp/wp-comments-post.php?unique_key.

    The change in line 105 is required. That function should be get_home_url() Can you test that configuration in a standard WP install and see if it will work?

    I never knew those 2 functions were different before I started using Bedrock. ??

    Plugin Author Gulshan Kumar

    (@thegulshankumar)

    I do not have BedRock setup in hand right now, can you email me please a demo site where I can perform the test?

    Plugin Author Gulshan Kumar

    (@thegulshankumar)

    Thank you @nicscott01 for your input.

    Please try the newer version; I have made changes according to your suggestions. It should work now.

    Let me know if you still need any assistance.

    • This reply was modified 8 months, 3 weeks ago by Gulshan Kumar.
    Thread Starter Nicscott01

    (@nicscott01)

    Thank you! v1.1.6 does the trick!

    Plugin Author Gulshan Kumar

    (@thegulshankumar)


    Fantastic news! ??

    Delighted to hear that it’s working smoothly for you! ?? Thanks for keeping me in the loop! ????

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Doesn’t work with Bedrock’ is closed to new replies.

Tags