Don’t define global .hidden css class

  • Resolved kontur

    (@kontur)


    7 years, 1 month ago

    In your frontend.css you define a class .hidden on a global scope.
    It would be advisable to make this class more specific, either by using other wrapping elements for specifying this style, or my making the class name itself more specific to your plugin.

    Like this it easily interferes with other theme or plugin styling.

Viewing 1 replies (of 1 total)
  • Plugin Author Diego

    (@daigo75)

    That class is global by design. It’s a simple, global .hidden precisely to be a generic, yet “low priority” rule, and interfere as little as possible with elements (themes or plugins) that might use a similar class for different purposes.

    A theme can easily avoid conflicts by adopting a more specific rule. That is, a rule like

    
.some-class .hidden {
  /* Some rules */
}

    Takes priority over .hidden, and that should prevent conflicts. The “final word” of styling lies within the theme, it should be easy enough to tweak the appearance of the elements.

    So far, we haven’t received a report of the .hidden class causing issues with themes or other plugins. If you found a case in which that causes an issue, we can have a look at it and prepare a rule to avoid a conflict.

    I also passed your note about using a “namespaced” class, such as .aelia-hidden, in a future release, to minimise the chance of clashes. It should be easy enough to change that.

Viewing 1 replies (of 1 total)
  • The topic ‘Don’t define global .hidden css class’ is closed to new replies.