Download button has no effect

This post is both a problem and solution, but I thought it might help some people.

I was able to upload files effectively, but downloads were a problem.

• Screen shots just displayed the last shot and wouldn’t scroll.
• The description was completely missing
• The Download button had no effect when clicked

I checked the browser developer console, and Firefox threw an error when trying to load script https://cdn.jquerytools.org/1.2.7/full/jquery.tools.min.js.

My site is strictly SSL (https), and Firefox would not allow inclusion of a file via http. This is considered a security risk, as it constitutes “mixed content”, as described here. Chrome wouldn’t allow this either. I didn’t test it with IE, but later versions of that probably wouldn’t like it either.

The jquerytools.org site doesn’t support https, so the only solution I could think of was to transfer the script to my own site and access that via the prevailing protocol. Thus, here’s what I did to fix this:

• Download jquery.tools.min.js from jquerytools.org
• Upload jquerytools.org to my own site
• Open wp-content/plugins/cm-download-manager/lib/controllers/CmdownloadController.php for editing.
• Down around line 398, edit this line in the overrideTemplate($template) function:
  wp_enqueue_script('jquery-tools', 'https://cdn.jquerytools.org/1.2.7/full/jquery.tools.min.js', array('jquery'));
• Change to something more like:
  wp_enqueue_script('jquery-tools', '//pnznol.net/js/jquery.tools.min.js', array('jquery'));

Note that I omitted the protocol from the url so it would use the currently prevailing protocol. Downloads began to work correctly after this change. Now I just have to remember to change this each time I update the plugin.

Since jquerytools.org doesn’t support https, it would be really great if I could configure CM Download Manager to use a configurable link for jquery.tools.min.js. That would allow the issue to be both well documented and easily solved. Alternatively, the plugin could include jquery.tools.min.js along with the product, and we could avoid the whole issue.

HTH

### Begin System Info ###

	Package Version:          1.0.7
	Multisite:                No

	SITE_URL:                 https://pnznol.net
	HOME_URL:                 https://pnznol.net

	WordPress Version:        4.6.1
	Permalink Structure:      /%year%/%monthnum%/%day%/%postname%/
	Active Theme:             Responsive Mobile 0.0.10
	
	Registered Post Stati:    publish, future, draft, pending, private, trash, auto-draft, inherit

	PHP Version:              5.5.36
	MySQL Version:            			
	Web Server Info:          Apache

	WordPress Memory Limit:   40M
	PHP Safe Mode:            No
	PHP Memory Limit:         256M
	PHP Upload Max Size:      1900M
	PHP Post Max Size:        2G
	PHP Upload Max Filesize:  1900M
	PHP Time Limit:           300
	PHP Max Input Vars:       1000
	PHP Arg Separator:        &
	PHP Allow URL File Open:  Yes
	WP_DEBUG:                 Disabled

	WP Table Prefix:          Length: 3 Status: Acceptable

	Show On Front:            page
	Page On Front:            Family (#2)
	Page For Posts:            (#0)

	WP Remote Post:           wp_remote_post() works

	Session:                  Enabled
	Session Name:             PHPSESSID
	Cookie Path:              /
	Save Path:                
	Use Cookies:              On
	Use Only Cookies:         On

	DISPLAY ERRORS:           N/A
	FSOCKOPEN:                Your server supports fsockopen.
	cURL:                     Your server supports cURL.
	SOAP Client:              Your server has the SOAP Client enabled.
	SUHOSIN:                  Your server does not have SUHOSIN installed.

	##COMPATIBILITY

	
		WordPress Version		4.6.1				OK
		Permalinks enabled		Yes				OK
		PHP Version		5.5.36				OK
		mbstring support		On				OK
		intl support		On				OK
		PHP Memory Limit		256M				OK
		PHP Max Upload Size		1900M				OK
		PHP Max Post Size		2G				OK
		PHP Max Execution Time		300				OK
		PHP cURL		On				OK
		PHP allow_url_fopen		1				OK
	
	##ACTIVE PLUGINS:

CM Download Manager: 2.5.10
Custom Meta Widget: 1.4.8
Google Apps Login: 2.9.7
jonradio Private Site: 2.14
Members: 1.1.2
### End System Info ###