Viewing 13 replies - 16 through 28 (of 28 total)
  • Mike, could you please test a patched version of the fancybox script file for me?

    Download https://plugins.svn.www.ads-software.com/easy-fancybox/trunk/fancybox/jquery.fancybox-1.3.4.pack.js (right click > Save as…) and overwrite your current /wp-content/plugins/easy-fancybox/fancybox/jquery.fancybox-1.3.4.pack.js file with it.

    Let me know the result ??

    Thread Starter mikdog

    (@mikdog)

    Hey thanks will try this now.

    I JUST got it working by doing this, as pointed out on the canvas forums:

    Hi Mike,
    I’ve read the thread over at WP.org and noticed the developer is trying to fix this issue.
    At the mean time, you can edit includes/theme-functions.php and change:
    // Set rel on anchor to show lightbox
    $rel = ‘rel=”lightbox[‘. $id .’]”‘;
    to
    // Set rel on anchor to show lightbox
    $rel = ”;
    Cheers,
    Tiago

    Will try the new file now,

    Thanks,

    Mike

    Thread Starter mikdog

    (@mikdog)

    Yep, new script seems to work well!

    Thanks again!!! That’s awesomeness.

    Excellent!

    You can keep using the patched file. It will be in the next release too.

    Thanks for reporting this issue and testing the patch. ??

    Thread Starter mikdog

    (@mikdog)

    Hi,

    So, not all too well in the land.

    How do I disable Easy FancyBox ONLY in the portfolio section?

    In the portfolio section now the categories don’t work:

    https://www.mikescottanimation.com/work

    And as you can see there are far too many thumbnails in the single post for the portfolio:

    https://www.mikescottanimation.com/portfolio-items/2007-2-bru-boegie-comics

    I think I may just have PrettyPhoto on the portfolio page and Easy FancyBox everywhere else. Possible?

    Thread Starter mikdog

    (@mikdog)

    I should probably add, the category issue was probably prevalent in the old version of the script too, I just didn’t test it until now. Same with the single page portfolio view.

    If you think you know the answer to how to get it working that’d be great, otherwise not to worry, I think you’ve already spent quite a bit of time on this and I’m very grateful. If, however, you know how I’d disable easy fancybox on a particular page (this case, portfolio) that would be super.

    Thanks again for all your help,

    Mike

    If you disable Easy FancyBox completely, do the categories in the portfolio work correctly then?

    Thread Starter mikdog

    (@mikdog)

    Hi RavanH,

    Thanks for the reply.

    Have disabled Easy Fancybox completely but not working.

    Normally, with PrettyPhoto enabled its supposed to work like this:

    https://www.thekiffness.com/portfolio

    (interestingly, LightBox Plus is also installed on this kiffness site but doesn’t seem to conflict from a user pov I think)

    I think the categories sorting may be a function of PrettyPhoto. So, with it disabled perhaps its not able to function correctly. I haven’t really changed too much code with the portfolio stuff, just commented out 3 lines I think as per Woo’s suggestions to disable it, but I’ll try uncommenting them and see if things work.

    Thread Starter mikdog

    (@mikdog)

    Re-enabling this line of code:

    wp_register_script( ‘prettyPhoto’, get_template_directory_uri() . ‘/includes/js/jquery.prettyPhoto.js’, array( ‘jquery’ ) );

    In my canvas/includes/theme-js.php file got the categories working again.

    Thread Starter mikdog

    (@mikdog)

    Also, re-enabling that line of code seems to have sorted out the single page post.

    I’ve probably got errors happening like crazy in the background, but it seems to work ok for now.

    Thanks,

    Mike

    Strange. The function that actually controls the portfolio categories is in https://www.mikescottanimation.com/wp-content/themes/canvas/includes/js/portfolio.js … maybe that one is not icluded when prettyPhoto is not included? You can check that by looking at the last parameter of the wp_register_script call that handles the portfolio.js inclusion. It probably says something like array('prettyPhoto','jquery'). I suspect you can remove prettyPhoto completely (improves page speed, if you’re not using it at all on the site) this way:

    Comment out the prettyPhoto inclusion line again and remove that 'prettyPhoto', (but leave 'jquery', or replace it with that) from the portfolio.js dependencies set on that last parameter in the portfolio.js inclusion line. Then edit the file canvas/includes/js/portfolio.js so that prettyPhoto function $("a[rel^='lightbox']").prettyPhoto(); is not used anymore. Which, I see, has already been done ??

    The suggestion above is not strictly necessary, it should just remove one of the many js libraries from loading on each page request…

    Anyway, good to hear it works ??

    Thread Starter mikdog

    (@mikdog)

    Phew!

    It took me reading and re-reading your post about 20 times, slower each time, to figure out what it meant (I’m not a coder in the least sense.)

    Finally figured out what you meant though by means of trial and error, and hey hey hey it works! I commented out that line that I re-enabled a post or two back, and deleted ‘prettyphoto’ from this last part:

    wp_register_script( ‘portfolio’, get_template_directory_uri() . ‘/includes/js/portfolio.js’, array( ‘jquery’, ‘prettyphoto’, ‘jCarousel’, ‘widgetSlider’ ) );

    (At least I think that’s what you meant).

    Works well. Thanks man, for all the help. So far so good. Seeing the light at the end of the tunnel, hopefully. Going to post this update on the Canvas forums.

    Mike, that is exactly what I meant ?? sorry for the confusing explanation and my congrats on your success in spite of that: great work!

    One more suggestion: you might try to look for a line in any of the theme’s functions.php files (I notice there are more that that usual 1 in the theme root dir) where it says something like

    wp_enqueue_style('prettyPhoto', get_template_directory_uri() . '/includes/css/prettyPhoto.css');

    This line takes care of inclusion of the prettyPhoto stylesheet which (I suspect) you don’t need any more too. Just to save you some more bandwidth ??

    Good luck!

Viewing 13 replies - 16 through 28 (of 28 total)
  • The topic ‘Easy FancyBox not showing YouTube videos’ is closed to new replies.