Edit markup

I suppose you *could* replace the entire wp_nav_menu_objects filter from the current plugin, but you’re right that adding a filter for just the HTML output would be cleaner and easier.

I’m in and out this weekend, but I’ll see about releasing a revision with the filter shortly.

PS: If you’re interesting in looking at it in the meantime, the lines I’ll be adjusting for filers will be:

// msi-frontend.php line 210
return "<i class='$size $icon $show_text'></i>";

and maybe:

// msi-frontend.php lines 231-233
if ( $this->hide_text ) {
    $item->title = '<span class="fa-hidden">' . $item->title . '</span>';
}

Thank you so much, Paul. I do appreciate your work.

Filters for both those items would be perfect!

I’ve released version 1.3.6 for you with the ability to override all HTML and CSS output.

Just copy the msi-templates directory to your theme, then edit the HTML in those files within your theme directory.

Hope that helps! Please take the time to submit a short review. It helps a lot!

Hey, thanks. That works, somewhat. I’d also like to be able to edit the anchor tag.

I don’t mean to be inconsiderate, but now you are forcing me to put that folder in the root of my themes folder … which I do not like. I keep my theme files very organized, and this is no bueno.

Any way I could get you to add a filter as well so I can override without using the templates?

Thank you!

Version 1.3.7 has been revised to use filters for the HTML output. See storm_social_icons_icon_html, storm_social_icons_title_html, and wp_nav_menu_objects documented in the plugin readme.

Link output is controlled by the wp_nav_menu_objects filter. It’s a WordPress core filter —?the same one Menu Social Icons uses to work. I’ve included how to edit link classes or add HTML inside the link in the example, but you can use:

echo '<pre>';
var_dump( $item );
echo '</pre>';

…to view all available settings for each menu item. (But not on a live site! It will output code!)

You might also find the WordPress core filters wp_nav_menu_items and wp_nav_menu_{$menu->slug}_items useful. They’re raw HTML, which is more difficult to reliably modify, but they do have their uses. You can find them around wp-includes/nav-menu-template.php:347

Also, please take the time to submit a short review!

Getting an error:
Notice: Undefined variable: title in /wp-content/plugins/menu-social-icons/classes/msi-frontend.php on line 234

If you add this line directly above, it will fix the issue.

$title = $item->title;

For wp_print_scripts():

public function wp_print_scripts() {
		$html = '
		<style>
			/* Accessible for screen readers but hidden from view */
			.fa-hidden { position:absolute; left:-10000px; top:auto; width:1px; height:1px; overflow:hidden; }
			.rtl .fa-hidden { left:10000px; }
			.fa-showtext { margin-right: 5px; }
		</style>';
		echo apply_filters( 'storm_social_icons_stylesheet', $html );
	}

Then we can do this:

// remove header style
function storm_social_icons_stylesheet( $html ) {
	return '';
}
add_filter( 'storm_social_icons_stylesheet', 'storm_social_icons_stylesheet' );

The other filter hooks are working perfectly! Thank you!

Notice fixed in 1.3.8. It should have been $item->title. Thanks.

A filter isn’t needed to disable stylesheet output —?instead, you would remove the hook:

add_action( 'template_redirect', 'remove_msi_stylesheet', 6 );
function remove_msi_stylesheet() {
	remove_action( 'wp_print_scripts', array( MSI_Frontend::get_instance(), 'wp_print_scripts' ) );
}

Thanks for taking the time to submit a review!

Ah ha. I have learned something about OOP! Thank you Paul.