Email Share Button

  • Resolved paulwylie2

    (@paulwylie2)


    4 years, 10 months ago

    Hey Robin

    I created a support topic about this issue before and I thought the issue was with my development site as it worked on a production site. However, I just tested it on the production site and the issue still occurs. The href attribute on the email share button is empty. It should be set to href=”mailto:” which is what should happen in your plugin (I remember you mentioned this before).

    I performed some troubleshooting and I think there may be a bug in the language translations for en_GB.

    To resolve the issue, I deleted the scriptlesssocialsharing plugin, installed and activated it again and the email sharing button work as expected (href is set to href=”mailto:). WordPress then prompts me that new translations are available, so I install the translations which are for the scriptlesssocialsharing plugin. The translations are for en_GB as I’m in the UK and the WordPress Site Language is set to ‘English (UK)’. After the installation of the translations, the email share button does not work as the href attribute is empty again.

    As a final test, if I change the WordPress Site Language to English (United States), the email share button works as expected and the href is set to href=”mailto:. When I change the WordPress Site Language back to ‘English (UK)’, the email share button does not work as href attribute is empty again.

    Thanks

    Paul

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Robin Cornett

    (@littlerchicken)

    Paul, thank you so much for reporting back on this. You are correct that it’s an issue with the GB translation–the translation changes the “Email” label to “E-mail”, which ends up breaking the email button output. This is due to a failure of imagination on my part–I’m using the button labels for naming classes in my code, and never thought about them being translatable. I need to think through the best way to manage this and hope to have it fixed in the next update. Thank you for the followup work in tracking this down; I really appreciate it!

    Plugin Author Robin Cornett

    (@littlerchicken)

    Paul, I’ve just released version 3.1.4 which should resolve this issue. Thanks for your patience.

    Thread Starter paulwylie2

    (@paulwylie2)

    Robin, I just updated plugin to 3.1.4 and the issue is resolved. Thanks for resolving it.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Email Share Button’ is closed to new replies.

Tags