Viewing 13 replies - 1 through 13 (of 13 total)
  • To fix this the plugin author should change line 1126 of wp-content/plugins/events-manager/classes/em-object.php from this:

    $page_args_escaped[$key] = $val && is_string($val) ? urlencode($val) : $val;

    To this:

    $page_args_escaped[$key] = $val && is_string($val) && $val != "%PAGE%" ? urlencode($val) : $val;
    Thread Starter robertomamoru

    (@robertomamoru)

    Thank you, @joneiseman

    I tested the proposed change and it worked perfectly. Waiting for the author to make the change.

    works like a charm – thank you, @joneiseman !
    now i can only hope it will be fixed in the next update.

    ??

    Thank you so much @joneiseman?! This was vexxing me for days. It worked perfectly.

    Well, glad to see I’m not the only one. Have fixed this myself some other way.
    Hope to see a final fix in the next version.

    Bob

    (@boblindner)

    We are seeing the same issue. Hopefully @msykes sees these and includes a fix in the next version, as pagination is completely broken.

    Thanks for the solution. Though, it seems that the new code in classes/em-object.php (added in v6.4.7) lines 1124 through 1127 where the $page_args_escaped variable is set/urlencoded is unnecessary because line 1128 uses em_add_get_params and that function is already urlencoding all of the values (the $encode parameter defaults to true), thus it’s being urlencoded twice (which is why we see %2525PAGE%2525 and then em-functions.php em_paginate doesn’t work because the placeholder is incorrect).

    Hoping for a fix with the next version.

    Plugin Author Marcus

    (@msykes)

    Hello, thanks for the suggestion @joneiseman we’ll review this and follow up with an update in the coming days. We had to push one urgently out just now for security.

    • This reply was modified 8 months, 2 weeks ago by Marcus.
    tobisoftware

    (@tobisoftware)

    Good evening,
    with the update to 6.4.7.2 it is broken again. Now the page number parameter looks like this pno=%25PAGE%25. Unfortunately, the solution described above no longer works.

    joneiseman

    (@joneiseman)

    Since the plugin author released a new version of the plugin without fixing this problem, you will need to reapply the fix. I just verified that the fix still works with version 6.4.7.2

    tobisoftware

    (@tobisoftware)

    Hello @joneiseman,

    thank you once again. Yes, your fix works. I had an error. Copy paste would have been better than typing by hand ??

    Wish you happy Easter holidays.

    Plugin Author Marcus

    (@msykes)

    Hi Everyone, this should now be fixed in the latest update, confirmations welcome!

    Thread Starter robertomamoru

    (@robertomamoru)

    Hi @msykes, confirmed, the pagination issue is fixed.
    I also checked the “Events Manager Demo Site” https://eventsmanager.site/shortcode/ working perfectly
    Thanks

Viewing 13 replies - 1 through 13 (of 13 total)
  • The topic ‘“events_list_grouped” pagination broken.Even on the Events Manager demo site’ is closed to new replies.