Expiry date in the past can be set during assignment creation

  • Resolved Heracles Michailidis

    (@ir4klis)


    6 years ago

    Hello,

    When creating an assignment/homework, an end date that is prior the starting date can be set.
    Normally, the end date should be always after the starting one.

    Plugin v.2.3.0.1

    Regards.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter Heracles Michailidis

    (@ir4klis)

    fixed in v.2.3.0.2

    @prasunsen Thanks for fixing it!

    Plugin Author Bob

    (@prasunsen)

    FYI, we have added validation only for from / to date. Not comparing to current date because for someone could be useful to just inactivate an assignment by letting the date in the past or editing old assignment etc.

    Thread Starter Heracles Michailidis

    (@ir4klis)

    Yes I noticed. Expiry date in the past as an option is useful.
    It was just the end date before start that was a minor user interface bug, not functional issue.

    Regards!

    Edit
    @prasunsen

    In views/homework.php , line 52

    You have (new Date(frm.accept_date_from.value).getTime() >= new Date(frm.accept_date_to.value).getTime())

    That way if the date is the same or the datepicker is not selected/hidden there is a popup.
    It’s better if you replace the >= with > .

    Plugin Author Bob

    (@prasunsen)

    @ir4klis you are right + having the same date is actually valid because someone may want to hold assignment for only one day. Fixed.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Expiry date in the past can be set during assignment creation’ is closed to new replies.