External images with lazy loading are broken

Hi @tofandel ,

That’s very odd… can you share the system info from the support tab of EWWW IO and can you point me to where I can see it in action? You can share it in a pastebin link or directly to us at https://ewww.io/contact-us/

Do you have anything else that might be doing lazy load (plugins or themes)? Is it on all images?

Not that I know, I disabled every other plugin

This is the code when EWWW lazyloading is enabled (and before js runs)

<img class="img lazyload" src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" data-src="https://https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg" decoding="async"><noscript><img class="img" src="https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg" data-eio="l"></noscript>

This is the code when EWWW is disabled

<img class="img" src="https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg">

Relevant debug log

<b>EWWW\Lazy_Load::validate_image_tag()</b>
<b>EWWW\Base::is_lazy_placeholder()</b>
found a valid image tag
original image tag: <img class="img" src="https://static.apidae-tourisme.com/filestore/objets-touristiques/images/254/220/12967166-diaporama.jpg">
<b>EWWW\Lazy_Load::parse_img_tag()</b>
<b>EWWW\Page_Parser::get_image_dimensions_by_url()</b>
getting dimensions for https://https&amp;#x3A;&amp;#x2F;&amp;#x2F;static.apidae-tourisme.com&amp;#x2F;filestore&amp;#x2F;objets-touristiques&amp;#x2F;images&amp;#x2F;254&amp;#x2F;220&amp;#x2F;12967166-diaporama.jpg
<b>EWWW\Page_Parser::get_dimensions_from_filename()</b>
looking for dimensions in https://https&amp;#x3A;&amp;#x2F;&amp;#x2F;static.apidae-tourisme.com&amp;#x2F;filestore&amp;#x2F;objets-touristiques&amp;#x2F;images&amp;#x2F;254&amp;#x2F;220&amp;#x2F;12967166-diaporama.jpg
<b>EWWW\Base::url_to_path_exists()</b>
trying to find path for https://https&amp;#x3A;&amp;#x2F;&amp;#x2F;static.apidae-tourisme.com&amp;#x2F;filestore&amp;#x2F;objets-touristiques&amp;#x2F;images&amp;#x2F;254&amp;#x2F;220&amp;#x2F;12967166-diaporama.jpg
not a valid local image
width attr:  and height attr: 
detected memory limit is: 270532608

• This reply was modified 5 months ago by Tofandel.
• This reply was modified 5 months ago by Tofandel.

It seems that the file has the url html encoded, which is then passed to esc_url (but the wordpress forum decodes them so it does not show correctly in the above output)

I’m providing a pastebin here with the html needed to reproduce the issue

https://pastebin.com/y85qNjEt

If you have this html in your page (which is valid html according to the specs, html attributes can be html encoded), EWWW will choke on this image and output it as https://https://

So it seems the output of get_images_from_html is missing an html_entity_decode

This is the line I changed to have it output correctly

$file = \str_replace( '&038;', '&', \esc_url( \trim( $file ) ) );

$file = \esc_url( \trim( html_entity_decode( $file ) ) );

• This reply was modified 5 months ago by Tofandel.
• This reply was modified 5 months ago by Tofandel.
• This reply was modified 5 months ago by Tofandel.
• This reply was modified 5 months ago by Tofandel.
• This reply was modified 5 months ago by Tofandel.
• This reply was modified 5 months ago by Yui.

Hi @tofandel,

I’m just checking in with you to let you know I haven’t abandoned this. I’ve been doing some tests on what you have sent over and looking at implementing something like this (if all goes well)!

Hi @tofandel

I think we managed to get it all working properly (including with our CDN) with your suggestions! Thank you! Would you mind testing it out on your side to make sure it works for you? You can get the updated version here: https://docs.ewww.io/article/73-update-from-github If we get the all-clear from you, we’ll include it in the next update.