• Hi,

    I noticed that Atahualpa (3.7.15) always calls for a favicon at

    <link rel=”shortcut icon” href=”https://mydomain.com/wp-content/ata-images/favicon.ico&#8221; />

    but the directory /ata-images/ does not exists. At all other places it looks at /atahualpa/ sub-directory. … Forgot to code it out when latest version of atahualpa was created?

    This shows up as extra URL visits in my visitor tracking software.

    let me know when it is fixed so that I can upgrade my theme.

    Thanks and best regards,
    Peter

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter peter achutha

    (@peter-achutha)

    I searched through the Atahualpa code and found this piece of code in the header.php file

    if ($bfa_ata['favicon_file'] != "") {
        if($bfa_ata['images_root'] == "atahualpa") {
               $imgdir  = get_template_directory_uri() . '/images/favicon/';
            } else {
    // at this point the images_root is 'wp-content'
        		if(!isset($bfa_ata['ata_images_dir'])
        		OR ($bfa_ata['ata_images_dir'] == '') ) {
               		$imgdir  = content_url() . '/ata-images/';
    			} else {
    				$imgdir  = content_url() . '/' . $bfa_ata['ata_images_dir'] . '/';
            	}
        	}

    I did not fully understand the code as I have not confirm the workings of a few functions like content_url(), … etc so I went back to the Atahualpa settings and noticed that the ‘set favicon’ option had a default file favicon.ico. I believe this may be a default setting but there is no such file in the favicon selection sub directory only those starting with 1-favicon.ico to fff-zoom.ico. There is no favicon.ico file here.

    I left the field blank, no favicon file defined and Atahualpa stopped searching for /index.php/wp-content/ata-images/favicon.ico url.

    I suspect that if it had checked whether the file did not exist it would not have tried to look for /index.php/wp-content/ata-images/favicon.ico. The code does not show whether it tests if the file exists before trying to load the favicon image.

    I hope this helps.

    Originally (per WordPress theme requirements) the favicon (and all images used by the theme) had to be in the theme folders, so the favicon was in the ‘atahualpa/images/favicon’ folder. The problem was that if you added your own favicon, everytime you did an automatic theme update your image would get wiped out because WordPress delete the entire contents of the theme folder before installing the new code.

    At this point the restriction has been lifted so the theme gives you a choice to create a new folder in the wp-content folder and stick your images there or continue using the Atahuala folders.

    There is an theme option (ATO->Image Location) that allows you to say which location you will use. If you pick the ‘wp-content’ option and put your images outside the theme folder, they will survive updates.

    If your having an issue using the ‘wp-content’ option, make sure to hit the SAVE button on that option.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘extra url called’ is closed to new replies.