FALSE POSITIVE: Showing bbPress as not PHP 7 Compatible

  • Resolved blackhawkcybersec

    (@blackhawkcybersec)


    8 years ago

    FILE: /XXXXXXXX/wp-content/plugins/bbpress/includes/admin/parser.php
    —————————————————————————————————————————————–
    FOUND 4 ERRORS AFFECTING 4 LINES
    —————————————————————————————————————————————–
    83 | ERROR | Use of deprecated PHP4 style class constructor is not supported since PHP 7
    1149 | ERROR | preg_replace() – /e modifier is forbidden since PHP 7.0
    1150 | ERROR | preg_replace() – /e modifier is forbidden since PHP 7.0
    1386 | ERROR | The use of function split is discouraged from PHP version 5.3 and forbidden from PHP version 7.0; use preg_split instead
    —————————————————————————————————————————————–

    FILE: /XXXXXXXX/wp-content/plugins/bbpress/includes/admin/converter.php
    —————————————————————————————————
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    —————————————————————————————————
    310 | WARNING | INI directive ‘safe_mode’ is deprecated from PHP 5.3 and forbidden from PHP 5.4.
    —————————————————————————————————

    Please fix.

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Contributor Jason Stallings

    (@octalmage)

    Thanks @blackhawkcybersec,

    I created a pull request for the first error: https://github.com/wimg/PHPCompatibility/pull/288
    I’ll create an issue for the second and third errors, and the forth error does appear to be an incompatibility.

    Thread Starter blackhawkcybersec

    (@blackhawkcybersec)

    The fourth error is in a function that is never called anywhere else in the code. Grep it and see for yourself. It will never get executed.

    Should they change it? Yes.

    Is it compatible with PHP 7? Yes.

    Moderator Stephen Edgar

    (@netweb)

    Hi, just as an FYI, the includes/admin/parser.php is an external library bbPress uses:
    ? https://sourceforge.net/projects/nbbc/

    I plan on updating a fork of the above repo to address the issue, see #2973

    Thread Starter blackhawkcybersec

    (@blackhawkcybersec)

    @netweb

    Roger that. That’s exactly what we had gathered. No worries. The plugin works fine on PHP 7 though. Thanks for the update.

    Thread Starter blackhawkcybersec

    (@blackhawkcybersec)

    @octalmage,

    Tested in version 1.3.0. That didn’t fix the the false positive issue. bbPress is being reported as not PHP 7 compatible, even though it works perfectly in PHP 7.

    Moderator Stephen Edgar

    (@netweb)

    FYI: I’m guessing bbPress might continue to fail this PHP7 test for a while, the NBBC 3rd party library included in bbPress won’t be updated for a while, I’ve just not the time at the moment.

    Thread Starter blackhawkcybersec

    (@blackhawkcybersec)

    @netweb

    No worries. Totally understand…you guys are busy. bbPress is working fine. If it’s code in a 3rd party library that doesn’t get executed, that doesn’t make it incompatible with PHP 7. The real issue is that PHP Compatibility Checker needs some major improvements, and at the very least needs to whitelist bbPress (and a lot of other plugins).

    Plugin Contributor Jason Stallings

    (@octalmage)

    This has been resolved by v1.3.1. Thanks for the report!

    Thread Starter blackhawkcybersec

    (@blackhawkcybersec)

    Thank you. Confirmed..it is being detected as PHP 7 compatible now.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘FALSE POSITIVE: Showing bbPress as not PHP 7 Compatible’ is closed to new replies.