Fancybox

  • Please consider fixing the “nofancybox” issue…

    I have to edit your plugin code (synved-social/synved-social.php) every time you update the plugin to keep the fancybox plugin happy.

    In your code:

    // don't use "nofancybox" because some plugins/themes interpret it as enabling fancybox
	$class_extra .= ' nolightbox';

    I have to change this to nofancybox every time. =(
    (I use the Easy Fancybox plugin.)

    IMO, those plugins that use “nofancybox” to enable fancybox are definitely doing it wrong, and you shouldn’t have to work around for their poor coding.

    Thanx for your consideration.. I really like what you’ve done with this plugin.

    https://www.ads-software.com/plugins/social-media-feather/

Viewing 3 replies - 1 through 3 (of 3 total)

  • The plugins don’t look for “nofancybox” they look for “fancybox” the problem is that “nofancybox” contains the word “fancybox” so they detect it. Unfortunately there are many more plugins using “fancybox” to detect than there are using “nofancybox” to disable.

    I’ll try and see if I can come up with a workaround for this that makes everyone happy. I might simply add a setting so that you at least don’t need to change the plugin’s files manually at each update.

    Heh, heh, I noticed this broke for me 2 months ago when updating from 1.7.1 to 1.7.4. I’m using Easy FancyBox 1.5.7 by RavanH, and it ignores “nolightbox” (at least for the Facebook share button). I got a FancyBox with the error “The requested content cannot be loaded.” Twitter, LinkedIn, and Email buttons correctly opened a new tab.

    So I reverted to 1.7.1 and held off on updating until I tried 1.7.8, which produced the same error. So I’m glad I found this thread so I could change it back to “nofancybox” – at least until the next update. Cheers.

    p.s. Thor.worx is correct: any developer who isn’t distinguishing between a string of “fancybox” and “nofancybox” isn’t writing very smart code. They’re doing a “contains” instead of a “matches”. Cheers.

    I agree that the coding of those plugins (and more problematic are actually themes with some JS to do this) but unfortunately I have to try and make our plugin work out of the box on as many installs as possible which caused this decision.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Fancybox’ is closed to new replies.