Fast, easy, great

Hi Alex,

thanks for your feedback! Great that you like my plugin ??
Any suggestions what I could improve?

Regards,

Kevin

I do have one suggestion… I only used your plugin for Vimeo videos. When you “share” a video on Vimeo you can select various options on how you’d like it to display which builds up a URL with a query string. When I tried to use this URL with the plugin, it generated something invalid that errored. I got around it by altering the settings on that particular video for how I wanted it to show every time on any web site. However it would be great to use the Vimeo sharing functionality to provide more flexibility.

If this doesn’t make sense, let me know!

Actually, a couple more suggestions which I think are more important:

1. The plugin injects script directly into the page. If it referenced an external JS file the browser can cache it, making the page load faster.

2. The script is injected on every page. It should only be injected on pages where the plugin is actually used, again for performance reasons.

Cheers!

To your first reply:
Can you send me your result after “altering the settings on that particular video”? (Link + What have you changed?)

To your second reply:
Great thanks for this handy tips! I’m going to improve the plugin with the next update.

Regards,

Kevin

Hi Kevin,

Now that i’ve had a look, I can’t find the screen on Vimeo that lets you add parameters to the URL. Perhaps they removed it? I guess instead you could try to parse and replace their iframe code and parameters that are documented here: https://developer.vimeo.com/player/embedding.

Some more thoughts on performance – if you decide to use an external JS file then you could provide it minified as well to get the lowest file size.

Cheers!