Fatal PHP error in 1.0.0.2b

  • Resolved David Anderson

    (@davidanderson)


    11 years, 1 month ago

    Whoops…

    $ wget -q https://downloads.www.ads-software.com/plugin/bruteprotect.zip
    $ unzip -q bruteprotect.zip
    $ php -l bruteprotect/admin/inc/plugin-install.php

    Parse error: syntax error, unexpected ‘[‘ in bruteprotect/admin/inc/plugin-install.php on line 6

    Errors parsing bruteprotect/admin/inc/plugin-install.php
    $ php -v
    PHP 5.3.20 (cli) (built: Dec 20 2012 06:20:32)
    Copyright (c) 1997-2012 The PHP Group
    Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies
    with Xdebug v2.1.4, Copyright (c) 2002-2012, by Derick Rethans

    The line:

    var $errors = [];

    is that a PHP 5.4-ism?

    Now that you’ve reached 1.0, any chance of less frequent updates? The update treadmill is tiring my clicking finger out! (Even with WordShell, which automatically detected the above PHP error before I installed – https://wordshell.net).

    David

    https://www.ads-software.com/plugins/bruteprotect/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Contributor Sam Hotchkiss

    (@samhotchkiss)

    Hey David– we knew about that problem, so the file you’re referencing there doesn’t get included (so this error wouldn’t happen when the plugin is activated)

    Sorry about the frequent updates this last week, we’re working on fixing the issue with that file so that we can include it, then we should be quiet on the update front for a while. Our long-term update plan is every 2 weeks.

    Thread Starter David Anderson

    (@davidanderson)

    Hi Sam,

    Thanks…

    For my two-cents worth, every 2 weeks is still too frequent, even if you have zero bugs and need no immediate fixes to show-stoppers that come with those 2-week releases. Personally, anything more than once a month (give or take those immediate fixes, which happen – that’s life) starts to get annoying and make me investigate alternative solutions for any particular plugin.

    David

    gecko_guy

    (@gecko_guy)

    Sam,

    My thanks again for your tremendous efforts and a great solution, but I agree with David Anderson.

    It is a real pain needing to constantly update plugins unless it really is for operational reasons, and this is particularly the case for developers/designers who maintain a large number of sites.

    Please bear this in mind if possible, although with such an important mechanism on a site I am happy to update as frequently as necessary if it does indeed help with protection.

    Guy

    Plugin Contributor Sam Hotchkiss

    (@samhotchkiss)

    Thanks for your feedback Guy and David– we will definitely keep this in mind and try to err toward fewer releases rather than more frequent.

    Thread Starter David Anderson

    (@davidanderson)

    Hi,

    Any chance that this invalid PHP could either be commented out, or the file removed? I realise that the file does not get included, but it still gets flagged up by my updating tools every time there’s a BruteProtect update, and I have to manually approve it. (I have tools which lint all plugin PHP before it goes live on a site – it’s saved me sometimes from bad plugin updates which authors have released – not you!).

    I don’t mean to whine about this. BruteProtect is great. It was just that I wondered if the issue would go away with the release of 2.0, since you mentioned in your original post that the file would eventually be included.

    Best wishes,
    David

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Fatal PHP error in 1.0.0.2b’ is closed to new replies.