Fatal PHP Error when trying to activate this plugin (with proposed fix)

  • Resolved KZeni

    (@kzeni)


    7 years, 5 months ago

    I found that I got a fatal PHP error when trying to activate the plugin (version 1.1.1). WordPress was reporting an unexpected case on line 3577 of includes/ls_button_widget.php.

    I ended up swapping out the multiple

    
<? if ( isset( $value[ 'note' ] ) ) { ?>
<br/>
<small><?php _e( $value[ 'note' ] ); ?></small><?php } ?>

    code blocks with

    
<?php if ( isset( $value[ 'note' ] ) ){ echo '<br/><small>'.$value[ 'note' ].'</small>'; } ?>

    and I found this fixed the issue! Though it appears simply swapping out instances of <? with <?php fixed the issue.

    Please, I would love this patch to be officially adopted in a plugin version update as I’m sure I’m not the only one where this compatibility issue prevented things from working properly (many setups don’t have the shortened <? enabled for use for PHP), and I can’t imagine how this change would cause a negative effect on anything.

    I’ve posted the fully patched version of the includes/ls_button_widget.php file here: https://gist.github.com/KZeni/f2e04fc154f0089589016d994ef9efc8

Viewing 1 replies (of 1 total)
  • Plugin Author Loomisoft

    (@loomisoft)

    Hi @kzeni

    Many thanks for pointing out the rookie mistake and many thanks for your contribution. We’re normally very good with PHP opening tags, but occasionally these mistakes do get through.

    We’ve just published version 1.1.2 to the repository, so feel free to update.

    We are actually planning making some big changes to the code within (mostly the behind the scenes code handling and structure and some to front-end functionality) so for the moment, we have just corrected the specific tags.

    Once again, many thanks. Much appreciated.

    Regards,

    Artem

Viewing 1 replies (of 1 total)
  • The topic ‘Fatal PHP Error when trying to activate this plugin (with proposed fix)’ is closed to new replies.