Favicon problem with themes like Dynamik

  • Resolved Jory Hogeveen

    (@keraweb)


    10 years, 1 month ago

    Hello,

    I’m working with a multisite installation and can’t get the favicon’s to work right in the “my sites” menu.

    I think the problem is that I work with generators like Dynamik themes. This theme stores the favicons in the uploads folder as a .png.

    this is the URL structure:
    https://www.website.nl/wp-content/uploads/sites/*siteid*/dynamik-gen/theme/images/favicon.png

    I’ve seen in your plugin that you work with a hardcodes stylesheet URL, is it possible to use the favicon filter without the stylesheet URL? (so just the root URL).

    And the problem is that I will need the current blog ID in the filter in order to get the right favicon path, I hope you can add these variables to the filter.

    https://www.ads-software.com/plugins/multisite-enhancements/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Frank Bueltge

    (@bueltge)

    If you will change the path for each favicon, please use a custom plugin like this example. The plugin have a filter for this requirement.
    https://github.com/bueltge/WordPress-Multisite-Enhancements/wiki/Filter-Hook-for-Favicon-File-Path

    Thread Starter Jory Hogeveen

    (@keraweb)

    I tried this, the problem is in the file: class-add-admin-favicon.php.

    The url that is printed has a fixed stylesheet-url variable before the hook function. So if I would return a custom url you would have this:

    **stylesheet url**/**custom url**

    I need a hook to completely overwrite the url to the favicon, not just the path from the stylesheet-url.
    Is this build in? If so, I can’t find it ??

    The reason is that allthough Genesis does put favicons in the “themes” folder, Dynamik doesn’t, Dynamik stores them in the “uploads” folder.

    Hope you can help me!

    Thread Starter Jory Hogeveen

    (@keraweb)

    I know how to solve this by the way, but I’ll have to make some changes to the file “class-add-admin-favicon.php”.
    And due to updates this is not the best solution.

    Is it ok if I make a request on Github?

    Thread Starter Jory Hogeveen

    (@keraweb)

    I’ve created a pull request on Github.
    This code works for me but maybe you can improve it.
    Let me know!

    Edit: I’ve added another change to align the favicons with the original WordPress icon.
    I don’t know if this is what you would like, but my guess whas that the WordPress logo can be shown when the blog doesn’t have a favicon.

    Plugin Author Frank Bueltge

    (@bueltge)

    Thanks a lot! Now released in Version 1.0.7.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Favicon problem with themes like Dynamik’ is closed to new replies.