Feature idea: Avoid versioning remote libraries

  • I’ve noticed that the plugin doesn’t remove the (wordpress default?) ?ver=4.9.6 from remote urls, like Google Fonts, jQuery, and so on.

    I think that’s because it doesn’t find anything local to get filemtime for, so it throws up hands and returns without changing the src.

    It’s possible that without this ?ver= param, loading from a canonical source, a viewer browser could have some libraries already in cache from another site. a mild perf boost.

    Adding the following line to the top of the autover_version_filter function fixes this behavior, so that if it can’t find the file locally, it gets no ?ver= param at all. 

    
	$src = remove_query_arg( 'ver', $src );

    Arguably a defect in wp core, not autover, but seems like a nice opportunity to make this plugin even better…

    Thanks,
    Chris

Viewing 1 replies (of 1 total)
  • Plugin Author Presslabs

    (@presslabs)

    Hello @chriscombsdc,

    Thank you for this great feature idea and for your kind quick implementation.

    I have opened an issue for this on our Github page for this plugin and we’ll get it implemented in the next Sprint.

    https://github.com/presslabs/autover/issues/15

    In the meantime, we might be able to merge it quicker if you consider opening up a PR and maybe adding in a test for this feature so we can get it approved faster.

    Best,
    ~Presslabs

Viewing 1 replies (of 1 total)
  • The topic ‘Feature idea: Avoid versioning remote libraries’ is closed to new replies.