Feedback and small suggestion

Hi there,

first of all: Great plugin and a very clean code. I don’t see that very often in the WP repository.

I have a minor suggestion to make. In my use case, I have HTML markup that contains rows (div elements with class “row”) which themself contain columns (div elements with class “col”).

Lets assume I want to set an equal height for columns in rows that have the class “eq-height”. Because I want to have the equal height of the columns on a per-row basis, I have to use a custom call on your plugin.

From a usability perspective, I would like to write a code similar to this:
$(“.row.eq-height”).each(function(i, e) {
$(e).find(“.col”).initEqualHeights();
});

I.e. for each row I find the columns and initialize the equal heights. However, I cannot do so because you use “this.selector” in the function call. “this” contains the correct elements, but “this.selector” is just “.col” in each call, which leads to faulty behavior.

I know how to get around this behavior – this is just a small suggestion to make this great plugin even better!

Best
M

• This topic was modified 8 years, 1 month ago by schlimpf.