• jhanten

    (@jhanten)


    I have modified some of your templates in a child theme and since this update my site was completely broken. I was wondering if you would consider providing a list of modified files for this release and future ones so that people like me would have some way to double check before updating? I’m going through the site now trying to sort this out file by file and it is a bit tedious. Thank you for a great theme and continuing to make it better.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Theme Author Ben Ritner – Kadence WP

    (@britner)

    Hey,
    With the latest update, around 55 files were changed, Mostly just improving code quality. There weren’t really any large changes that should have effected a site unless you were modifying PHP functions files which would be different then template files. If you are modifying functions files then that would break and in general will frequently break since functions files are treated much differently then template files.

    If you need to modify a function I probably have a better solution for you then treating a functions file like a template and overriding it in your child theme.

    I would be happy to provide assistance to do this if you send me what you’re wanting to change then I can give you a filter or action function that would give you a safe long-term way to make the change. If there isn’t a safe long-term way to make the change you’re wanting then I can update the theme and create it.

    Ben

    Thread Starter jhanten

    (@jhanten)

    I had modified some of the template files and put them into a child theme. I realize now that I should have only left the changed files, but had most of the template folder in the child theme. So that was my fault. Basically I was just disabling the display of categories and Tags inside the entry-meta-subhead.php. I think that is the only change I made so I really think if I had not left the whole template folder in the child theme it probably wouldn’t have broken everything with your code clean up. The error I was getting was that the site was calling functions that didn’t exist. Anyway everything is fine now. If you do have a better way to do what I am doing I would be interested in learning. I’m still not really good with filters and action functions with child themes. Thank you.

    tapper101

    (@tapper101)

    I just want to second this. My site broke as well, every page using a custom template is blank (except for the header).

    I haven’t modified anything in functions.php in my child theme, I’m simply enqueueing scripts/styles, registering custom post types, and registering a widget area. The only Virtue theme related code I have there is

    add_filter('kadence_display_sidebar', 'kt_remove_all_sidebars');
    
    function kt_remove_all_sidebars($sidebar) {
    
        return false;
    
    }

    So I’m going to assume it’s something wrong with my templates.

    Thankfully it’s my test site (duplicate of main site) that is broken by this update, I haven’t updated the main site yet until I can figure out how to fix this. (Thank god for test sites).

    My templates are simplified copies of the Virtue ones, only thing left in them (of the original code) is:

    <?php 
                    /**
                    * @hooked virtue_page_comments - 20
                    */
                    do_action('kadence_page_footer');
                    ?>

    As well as this (though I assume this is irrelevant): <?php get_template_part(‘templates/page’, ‘header’); ?> and <?php echo esc_attr(kadence_main_class()); ?>

    I’ll try to figure this out.. I’ll look at the templates in the main theme.

    tapper101

    (@tapper101)

    Wow, OK. Turns out it was <?php echo esc_attr(kadence_main_class()); ?> that was used as a class in the main div. I changed it to

    <div class="main <?php echo esc_attr(virtue_main_class()); ?>" role="main">

    And it works again. I assume you changed a lot of the kadence into virtue in your actions, etc. I think you’ve changed the footer action to do_action(‘virtue_page_footer’); as well?

    Hopefully this will help others with the same problem.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Files changed list for Oct 25 update 3.0.7’ is closed to new replies.