Filter by Event Location issue

  • Resolved joergpe

    (@joergpe)


    1 year, 5 months ago

    Hi Joe,
    many thanks for the great Calendar Plugin.

    I came about a bug in Version V3.4.16 WP 6.2.2, I think you have worked on this issue but it is still present, compare (https://www.ads-software.com/support/topic/event-location-disappears-when-editing-event-description/)

    When I create a calendar with one event at location1 the event is shown in grid view as expected. The filter for this location works, the event is shown when location1 is selected and hidden when location2 is selected:

    Now I edit the Event, change nothing, just click on Update and go back to the grid view and filter for Location1, the event is gone:

    I have to edit the event, change location to the same location and update the event, to get it back in the gridview:

    Can you please look into this?
    Or is the problem maybe not present in the Pro Version?

    Many thanks,
    J?rg

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Joe Dolson

    (@joedolson)

    I’ve looked at this, and as of yet I haven’t been able to reproduce it in the latest version of My Calendar; it seems like there may be some specific environmental information that I’m not reproducing. It shouldn’t be impacted by Pro in anyway; I tested without.

    Is there any additional detail, however small, that I may be missing in how you’re editing events? It seems like the problem is that the location goes away when you edit an event, but I haven’t been able to reproduce that issue.

    Thread Starter joergpe

    (@joergpe)

    I have a clean WP 6.2.2 Installation without any other plugins. The problem appears always when I add an event with a location and update this event with the location drop down box in the state of “no change”.

    I digged into the source code and I think I found the problem in my-calendar-event-editor.php line 2221:

    // Set location.
    if ( ‘none’ === $location_preset && ( empty( $post[‘event_label’] ) || is_numeric( $event_location ) ) ) {
    // event location name is required to copy over.
    } else {

    I think it should be !is_numeric( $event_location )
    because otherwise the block at line 2244 will not be executed and this is needed to keep the location data of the event.

    Would be great if you can update the file.

    Plugin Author Joe Dolson

    (@joedolson)

    Can you add this as an issue on my github repository? https://github.com/joedolson/my-calendar/ Thanks!

    Thread Starter joergpe

    (@joergpe)

    https://github.com/joedolson/my-calendar/issues/557

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Filter by Event Location issue’ is closed to new replies.